Refactor OverlayStrategySandwich and OverlayStrategyCommon

Refactor OverlayStrategySandwich and OverlayStrategyCommon.

Separate OverlayStrategySandwich from OverlayStrategyCommon to make it simpler.
Delete OverlayStrategyCommon since all that remains is a loop.
Also remove no longer used device_scale_factor parameter.

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
CQ_EXCLUDE_TRYBOTS=tryserver.chromium.linux:linux_android_rel_ng

Committed: https://crrev.com/8b978787993d1dfceea7e8f841428cb6db7bb3e2
Cr-Commit-Position: refs/heads/master@{#352473}

[Andre, 2015-10-01 18:13:30]

Patchset #1 (id:1) has been deleted

[Andre, 2015-10-01 18:24:06]

Patchset #1 (id:20001) has been deleted

[Andre, 2015-10-01 18:27:22]

andresantoso@chromium.org changed reviewers:
+ ccameron@chromium.org

[Andre, 2015-10-01 18:27:23]

PTAL.
Once your CL moves the primary plane out from OverlayStrategyCommon, I think we
don't really need OverlayStrategyCommon anymore since all the remains is a loop.

[ccameron, 2015-10-01 19:05:54]

Good point -- we should probably go even further, and just remove
OverlayStrategyCommon entirely.

[Andre, 2015-10-01 22:52:59]

Patchset #2 (id:50001) has been deleted

[Andre, 2015-10-01 22:58:21]

On 2015/10/01 19:05:54, ccameron wrote:
> Good point -- we should probably go even further, and just remove
> OverlayStrategyCommon entirely.

Done, OverlayStrategyCommon deleted.
alexst PTAL as well.

[Andre, 2015-10-05 17:55:15]

ccameron, alexst, ping?

[ccameron, 2015-10-05 19:16:50]

On 2015/10/05 17:55:15, Andre wrote:
> ccameron, alexst, ping?

(taking a look)

[ccameron, 2015-10-05 19:28:29]

lgtm, very happy with this reorganization.

https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
File cc/output/overlay_strategy_all_or_nothing.h (left):

https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
cc/output/overlay_strategy_all_or_nothing.h:25: float device_scale_factor)
override;
Thanks for killing this ....

https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
File cc/output/overlay_strategy_single_on_top.cc (right):

https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
cc/output/overlay_strategy_single_on_top.cc:23: QuadList& quad_list =
render_passes->back()->quad_list;
Just out of curiosity, any reason you didn't inline TryOverlay here (but did in
Underlay strategy)? I sort-of like the more compact inlined version, FWIW.

[Andre, 2015-10-05 20:24:20]

https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
File cc/output/overlay_strategy_single_on_top.cc (right):

https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
cc/output/overlay_strategy_single_on_top.cc:23: QuadList& quad_list =
render_passes->back()->quad_list;
On 2015/10/05 19:28:29, ccameron wrote:
> Just out of curiosity, any reason you didn't inline TryOverlay here (but did
in
> Underlay strategy)? I sort-of like the more compact inlined version, FWIW.

To inline, the "return false" in line 48 needs to become "continue" for the
outer for loop (line 24), so it became messy.

[Andre, 2015-10-05 20:25:31]

On 2015/10/05 20:24:20, Andre wrote:
>
https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
> File cc/output/overlay_strategy_single_on_top.cc (right):
> 
>
https://codereview.chromium.org/1372103005/diff/70001/cc/output/overlay_strat...
> cc/output/overlay_strategy_single_on_top.cc:23: QuadList& quad_list =
> render_passes->back()->quad_list;
> On 2015/10/05 19:28:29, ccameron wrote:
> > Just out of curiosity, any reason you didn't inline TryOverlay here (but did
> in
> > Underlay strategy)? I sort-of like the more compact inlined version, FWIW.
> 
> To inline, the "return false" in line 48 needs to become "continue" for the
> outer for loop (line 24), so it became messy.

I meant to say, there's no clean way to "continue" to an outer for loop.

[Andre, 2015-10-05 20:25:38]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-10-05 20:26:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372103005/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372103005/70001

[Andre, 2015-10-05 23:00:44]

The CQ bit was unchecked by andresantoso@chromium.org

[Andre, 2015-10-05 23:00:47]

The CQ bit was checked by andresantoso@chromium.org

[commit-bot: I haz the power, 2015-10-05 23:01:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1372103005/70001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1372103005/70001

[commit-bot: I haz the power, 2015-10-06 00:14:32]

Committed patchset #2 (id:70001)

[commit-bot: I haz the power, 2015-10-06 00:15:51]

Patchset 2 (id:??) landed as
https://crrev.com/8b978787993d1dfceea7e8f841428cb6db7bb3e2
Cr-Commit-Position: refs/heads/master@{#352473}