Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1372873004: Refactor OverlayTest to make it easier to test additional strategies. (Closed)

Created:
5 years, 2 months ago by Andre
Modified:
5 years, 2 months ago
Reviewers:
ccameron
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@clip
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor OverlayTest to make it easier to test additional strategies. Refactor to remove code duplication between OverlayTest and SandwichTest. This is to make it easier to add tests for new strategies, such as the upcoming AllOrNothing strategy. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/e34f77dea96ba7d862d1631e7490a102a698cd4f Cr-Commit-Position: refs/heads/master@{#351392}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -84 lines) Patch
M cc/output/overlay_unittest.cc View 6 chunks +53 lines, -84 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (2 generated)
Andre
ccameron PTAL.
5 years, 2 months ago (2015-09-29 20:26:45 UTC) #2
ccameron
Much better. lgtm
5 years, 2 months ago (2015-09-29 20:37:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372873004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372873004/1
5 years, 2 months ago (2015-09-29 20:39:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-29 20:46:00 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 20:47:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e34f77dea96ba7d862d1631e7490a102a698cd4f
Cr-Commit-Position: refs/heads/master@{#351392}

Powered by Google App Engine
This is Rietveld 408576698