Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 137273003: Mojo: Rename PlatformChannelHandle to PlatformHandle, etc. (Closed)

Created:
6 years, 11 months ago by viettrungluu
Modified:
6 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, darin (slow to review), viettrungluu+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium
Visibility:
Public.

Description

Mojo: Rename PlatformChannelHandle to PlatformHandle, etc. We're going to need handles to things other than "channels", so rename PlatformChannelHandle to PlatformHandle. Rename/refactor PlatformChannel to ScopedPlatformHandle (because that's what it really was), and make it move-only. Adapt everything else to fit this model. R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244742

Patch Set 1 #

Patch Set 2 : win fixes #

Patch Set 3 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+221 lines, -381 lines) Patch
M mojo/common/test/multiprocess_test_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/common/test/multiprocess_test_base.cc View 5 chunks +9 lines, -12 lines 0 comments Download
M mojo/common/test/multiprocess_test_base_unittest.cc View 6 chunks +11 lines, -21 lines 0 comments Download
M mojo/mojo.gyp View 1 2 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/system/channel.h View 2 chunks +6 lines, -3 lines 0 comments Download
M mojo/system/channel.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/system/multiprocess_message_pipe_unittest.cc View 5 chunks +12 lines, -13 lines 0 comments Download
D mojo/system/platform_channel.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/system/platform_channel.cc View 1 chunk +0 lines, -36 lines 0 comments Download
D mojo/system/platform_channel_handle.h View 1 chunk +0 lines, -46 lines 0 comments Download
D mojo/system/platform_channel_handle.cc View 1 chunk +0 lines, -37 lines 0 comments Download
M mojo/system/platform_channel_pair.h View 3 chunks +21 lines, -25 lines 0 comments Download
M mojo/system/platform_channel_pair.cc View 1 chunk +4 lines, -23 lines 0 comments Download
M mojo/system/platform_channel_pair_posix.cc View 5 chunks +9 lines, -10 lines 0 comments Download
A + mojo/system/platform_handle.h View 4 chunks +10 lines, -9 lines 0 comments Download
A + mojo/system/platform_handle.cc View 1 2 chunks +7 lines, -4 lines 0 comments Download
M mojo/system/raw_channel.h View 3 chunks +7 lines, -5 lines 0 comments Download
M mojo/system/raw_channel_posix.cc View 12 chunks +18 lines, -20 lines 0 comments Download
M mojo/system/raw_channel_posix_unittest.cc View 13 chunks +30 lines, -52 lines 0 comments Download
M mojo/system/raw_channel_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M mojo/system/remote_message_pipe_posix_unittest.cc View 4 chunks +5 lines, -9 lines 0 comments Download
A mojo/system/scoped_platform_handle.h View 1 chunk +61 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
More notes: - I'll need to expose PlatformHandle/ScopedPlatformHandle to the embedder API. I might move ...
6 years, 11 months ago (2014-01-13 23:56:09 UTC) #1
darin (slow to review)
LGTM
6 years, 11 months ago (2014-01-14 05:57:27 UTC) #2
viettrungluu
6 years, 11 months ago (2014-01-14 16:30:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r244742 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698