Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: mojo/system/platform_handle.cc

Issue 137273003: Mojo: Rename PlatformChannelHandle to PlatformHandle, etc. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebased Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/platform_handle.h ('k') | mojo/system/raw_channel.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/platform_handle.cc
diff --git a/mojo/system/platform_channel_handle.cc b/mojo/system/platform_handle.cc
similarity index 72%
rename from mojo/system/platform_channel_handle.cc
rename to mojo/system/platform_handle.cc
index f762c7a498ee8218403011f6e27810279d2fc553..e36d746f283e96ec7970157c08057056f8715214 100644
--- a/mojo/system/platform_channel_handle.cc
+++ b/mojo/system/platform_handle.cc
@@ -2,7 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "mojo/system/platform_channel_handle.h"
+#include "mojo/system/platform_handle.h"
#include "build/build_config.h"
#if defined(OS_POSIX)
@@ -13,20 +13,23 @@
#error "Platform not yet supported."
#endif
+#include "base/compiler_specific.h"
#include "base/logging.h"
namespace mojo {
namespace system {
-void PlatformChannelHandle::CloseIfNecessary() {
+void PlatformHandle::CloseIfNecessary() {
if (!is_valid())
return;
#if defined(OS_POSIX)
- DPCHECK(close(fd) == 0);
+ bool success = (close(fd) == 0);
+ DPCHECK(success);
fd = -1;
#elif defined(OS_WIN)
- DPCHECK(CloseHandle(handle));
+ bool success = !!CloseHandle(handle);
+ DPCHECK(success);
handle = INVALID_HANDLE_VALUE;
#else
#error "Platform not yet supported."
« no previous file with comments | « mojo/system/platform_handle.h ('k') | mojo/system/raw_channel.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698