Mac Overlays: Allow the primary plane to be optionally scheduled.

Mac Overlays: Allow the primary plane to be optionally scheduled.

When AllOrNothing strategy get enabled, it will not schedule the primary plane
when it successfully promoted all quads into overlays.

Also removed OverlayPlane::Type, it is no longer needed.

BUG=533687
Committed: https://crrev.com/6668d0b2af0f890308a9b8625c02d09f9d354fad
Cr-Commit-Position: refs/heads/master@{#352609}

[Andre, 2015-10-05 20:30:10]

andresantoso@chromium.org changed reviewers:
+ ccameron@chromium.org

[Andre, 2015-10-05 20:30:10]

ccameron PTAL.

[ccameron, 2015-10-05 20:44:42]

lgtm

https://codereview.chromium.org/1369243005/diff/1/content/common/gpu/image_tr...
File content/common/gpu/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/1369243005/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_overlay_mac.mm:158: [ca_layer
removeFromSuperlayer];
I was vaguely concerned about this having odd interactions with CAContext, but
if this works, sounds good to me.

https://codereview.chromium.org/1369243005/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_overlay_mac.mm:639: if (image)
Do we need this -- is image ever nullptr?

[Andre, 2015-10-05 20:53:13]

https://codereview.chromium.org/1369243005/diff/1/content/common/gpu/image_tr...
File content/common/gpu/image_transport_surface_overlay_mac.mm (right):

https://codereview.chromium.org/1369243005/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_overlay_mac.mm:158: [ca_layer
removeFromSuperlayer];
On 2015/10/05 20:44:42, ccameron wrote:
> I was vaguely concerned about this having odd interactions with CAContext, but
> if this works, sounds good to me.

We could check if ([ca_layer superlayer]), but removeFromSuperlayer should do
the same check.

https://codereview.chromium.org/1369243005/diff/1/content/common/gpu/image_tr...
content/common/gpu/image_transport_surface_overlay_mac.mm:639: if (image)
On 2015/10/05 20:44:42, ccameron wrote:
> Do we need this -- is image ever nullptr?

This was leftover from scheduling SolidColor tiles through here, it's never
nullptr otherwise.
Fixed in patchset 2.

[Andre, 2015-10-05 20:53:40]

Patchset #2 (id:20001) has been deleted

[Andre, 2015-10-06 15:39:00]

The CQ bit was checked by andresantoso@chromium.org

[Andre, 2015-10-06 15:39:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
ccameron@chromium.org
Link to the patchset: https://codereview.chromium.org/1369243005/#ps40001
(title: "For ccameron")

[commit-bot: I haz the power, 2015-10-06 15:39:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1369243005/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1369243005/40001

[commit-bot: I haz the power, 2015-10-06 15:44:36]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-10-06 15:45:32]

Patchset 2 (id:??) landed as
https://crrev.com/6668d0b2af0f890308a9b8625c02d09f9d354fad
Cr-Commit-Position: refs/heads/master@{#352609}