Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2295)

Unified Diff: chrome/browser/resources/settings/location_page/site_list.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Polish Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/location_page/site_list.html
diff --git a/chrome/browser/resources/settings/location_page/site_list.html b/chrome/browser/resources/settings/location_page/site_list.html
new file mode 100644
index 0000000000000000000000000000000000000000..114873427abd5cdee25701d69a547514e8f58314
--- /dev/null
+++ b/chrome/browser/resources/settings/location_page/site_list.html
@@ -0,0 +1,51 @@
+<link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communication-icons.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.html">
+<link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submenu.html">
+
+<dom-module id="settings-site-list">
+ <link rel="import" type="css"
+ href="chrome://md-settings/settings_page/settings_page.css">
Dan Beam 2015/10/19 07:18:06 unwrap and/or remove chrome://md-settings/
Finnur 2015/10/19 13:53:59 Done.
+ <link rel="import" type="css" href="site_list.css">
+ <template>
+ <paper-menu>
+ <paper-submenu>
+ <paper-item class="menu-trigger">
Dan Beam 2015/10/19 07:18:06 why is it a menu with only a submenu? probably onl
Finnur 2015/10/19 13:53:59 Sure. A sole <paper-submenu> seems to work just fi
+ <div>[[computeSiteListHeader_(siteList_, toggleState_)]]</div>
+ </paper-item>
+ <paper-menu class="menu-content">
+ <template is="dom-repeat" items="{{siteList_}}">
Dan Beam 2015/10/19 07:18:06 can we use iron-list instead?
Finnur 2015/10/19 13:53:59 Hmm... I'm able to construct a free-standing iron-
+ <div class="horizontal layout center">
+ <div><iron-icon
Dan Beam 2015/10/19 07:18:06 don't put two tags on the same line unless the clo
Finnur 2015/10/19 13:53:59 Done (in other file).
+ icon="[[computeSiteIcon_(item.url)]]"
+ item-icon></iron-icon></div>
+ <div class="flex"><paper-item
+ on-click="handleClick_">[[item.url]]</paper-item></div>
+ <div>
+ <paper-menu-button>
+ <paper-icon-button icon="menu" class="dropdown-trigger"
+ alt="menu"></paper-icon-button>
+ <paper-menu id="actionMenu" class="dropdown-content"
+ on-iron-select="onActionMenuIronSelect_">
+ <template is="dom-if" if="[[showAllowAction_]]">
+ <paper-item
+ value="Allow">[[allowActionLabel_]]</paper-item>
Dan Beam 2015/10/19 07:18:06 don't use the literal "Allow" here. instead use a
Finnur 2015/10/19 13:53:59 Done.
+ </template>
+ <template is="dom-if" if="[[showBlockAction_]]">
+ <paper-item
+ value="Block">[[blockActionLabel_]]</paper-item>
+ </template>
+ <paper-item value="Reset">[[resetActionLabel_]]</paper-item>
+ </paper-menu>
+ </paper-menu-button>
+ </div>
+ </div>
+ </template>
+ </paper-menu>
+ </paper-submenu>
+ </paper-menu>
+ </template>
+ <script src="site_list.js"></script>
+</dom-module>

Powered by Google App Engine
This is Rietveld 408576698