chrome/browser/resources/settings/location_page/site_list.html - Issue 1372053002: Flesh out the location-page class to make it more general.

Side by Side Diff: chrome/browser/resources/settings/location_page/site_list.html

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polish Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/resources/settings/advanced_page/advanced_page.js ('K') | « chrome/browser/resources/settings/location_page/location_page.js ('k') | chrome/browser/resources/settings/location_page/site_list.js » ('j') | chrome/browser/resources/settings/location_page/site_list.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">

	2 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classe s/iron-flex-layout.html">

	3 <link rel="import" href="chrome://resources/polymer/v1_0/iron-icons/communicatio n-icons.html">

	4 <link rel="import" href="chrome://resources/polymer/v1_0/paper-item/paper-item.h tml">

	5 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-menu.h tml">

	6 <link rel="import" href="chrome://resources/polymer/v1_0/paper-menu/paper-submen u.html">

	7

	8 <dom-module id="settings-site-list">

	9 <link rel="import" type="css"

	10 href="chrome://md-settings/settings_page/settings_page.css">
	Dan Beam 2015/10/19 07:18:06 unwrap and/or remove chrome://md-settings/ unwrap and/or remove chrome://md-settings/ Finnur 2015/10/19 13:53:59 Done. Done.
	11 <link rel="import" type="css" href="site_list.css">

	12 <template>

	13 <paper-menu>

	14 <paper-submenu>

	15 <paper-item class="menu-trigger">
	Dan Beam 2015/10/19 07:18:06 why is it a menu with only a submenu? probably onl why is it a menu with only a submenu? probably only need one or the other, no? Finnur 2015/10/19 13:53:59 Sure. A sole <paper-submenu> seems to work just fi Sure. A sole <paper-submenu> seems to work just fine.
	16 <div>[[computeSiteListHeader_(siteList_, toggleState_)]]</div>

	17 </paper-item>

	18 <paper-menu class="menu-content">

	19 <template is="dom-repeat" items="{{siteList_}}">
	Dan Beam 2015/10/19 07:18:06 can we use iron-list instead? can we use iron-list instead? Finnur 2015/10/19 13:53:59 Hmm... I'm able to construct a free-standing iron- Hmm... I'm able to construct a free-standing iron-list showing my data, but simply the act of moving it inside my paper-menu causes it to refuse to draw any content. I tried sending the iron-resize event, but that seemed to do nothing and despite playing with it for a while I was not able to get it to do what I wanted... :/
	20 <div class="horizontal layout center">

	21 <div><iron-icon
	Dan Beam 2015/10/19 07:18:06 don't put two tags on the same line unless the clo don't put two tags on the same line unless the close on the same line Finnur 2015/10/19 13:53:59 Done (in other file). Done (in other file).
	22 icon="[[computeSiteIcon_(item.url)]]"

	23 item-icon></iron-icon></div>

	24 <div class="flex"><paper-item

	25 on-click="handleClick_">[[item.url]]</paper-item></div>

	26 <div>

	27 <paper-menu-button>

	28 <paper-icon-button icon="menu" class="dropdown-trigger"

	29 alt="menu"></paper-icon-button>

	30 <paper-menu id="actionMenu" class="dropdown-content"

	31 on-iron-select="onActionMenuIronSelect_">

	32 <template is="dom-if" if="[[showAllowAction_]]">

	33 <paper-item

	34 value="Allow">[[allowActionLabel_]]</paper-item>
	Dan Beam 2015/10/19 07:18:06 don't use the literal "Allow" here. instead use a don't use the literal "Allow" here. instead use a constant so we can't misspell it Finnur 2015/10/19 13:53:59 Done. Done.
	35 </template>

	36 <template is="dom-if" if="[[showBlockAction_]]">

	37 <paper-item

	38 value="Block">[[blockActionLabel_]]</paper-item>

	39 </template>

	40 <paper-item value="Reset">[[resetActionLabel_]]</paper-item>

	41 </paper-menu>

	42 </paper-menu-button>

	43 </div>

	44 </div>

	45 </template>

	46 </paper-menu>

	47 </paper-submenu>

	48 </paper-menu>

	49 </template>

	50 <script src="site_list.js"></script>

	51 </dom-module>

OLD	NEW