chrome/browser/resources/settings/advanced_page/advanced_page.js - Issue 1372053002: Flesh out the location-page class to make it more general.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/advanced_page/advanced_page.js

Issue 1372053002: Flesh out the location-page class to make it more general. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polish Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/advanced_page/advanced_page.html ('K') | « chrome/browser/resources/settings/advanced_page/advanced_page.html ('k') | chrome/browser/resources/settings/compiled_resources.gyp » ('j') | chrome/browser/resources/settings/location_page/site_list.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/advanced_page/advanced_page.js

diff --git a/chrome/browser/resources/settings/advanced_page/advanced_page.js b/chrome/browser/resources/settings/advanced_page/advanced_page.js

index 0943c0dd85da65f4a34129232fc8837b89c40e15..7dd61550384566655889723865ed2f9f9c1509fc 100644

--- a/chrome/browser/resources/settings/advanced_page/advanced_page.js

+++ b/chrome/browser/resources/settings/advanced_page/advanced_page.js

@@ -38,4 +38,9 @@ Polymer({

notify: true,

+ ready: function() {

+ this.$.locationCategory.category =

+ siteSettings.ContentSettingsTypes.GEOLOCATION;

Dan Beam 2015/10/19 07:18:06 why can't this be done from within the page itself

Finnur 2015/10/19 13:53:58 See answer elsewhere.

+ },

});