Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1371893002: objects-inl.h: Remove ACCESSORS_TO_SMI macro (Closed)

Created:
5 years, 2 months ago by Jakob Kummerow
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

objects-inl.h: Remove ACCESSORS_TO_SMI macro Replacing it with SMI_ACCESSORS. This change makes accesses to Smi fields in objects more regular (the accessors now always consume/return an int rather than a Smi*), which avoids a bunch of manual Smi::FromInt() and Smi::value() conversions, and is a step on the way towards being able to generate objects-inl.h. Committed: https://crrev.com/7117acd26c04c7bcfda20d8f55b7e5ec8418439c Cr-Commit-Position: refs/heads/master@{#30975}

Patch Set 1 #

Total comments: 1

Patch Set 2 : undo last_script_id storage change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+140 lines, -165 lines) Patch
M src/accessors.cc View 5 chunks +11 lines, -8 lines 0 comments Download
M src/allocation-tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/api.cc View 4 chunks +9 lines, -9 lines 0 comments Download
M src/bootstrapper.h View 1 chunk +1 line, -1 line 0 comments Download
M src/bootstrapper.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compilation-cache.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/compiler.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M src/d8.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/debug/debug.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M src/factory.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/heap/heap.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M src/heap/heap-inl.h View 1 1 chunk +9 lines, -6 lines 0 comments Download
M src/isolate.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M src/log-inl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/messages.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 10 chunks +22 lines, -27 lines 0 comments Download
M src/objects.cc View 1 5 chunks +8 lines, -9 lines 0 comments Download
M src/objects-debug.cc View 4 chunks +0 lines, -9 lines 0 comments Download
M src/objects-inl.h View 1 13 chunks +35 lines, -51 lines 0 comments Download
M src/objects-printer.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M src/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/profile-generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/scopes.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
Jakob Kummerow
WDYT?
5 years, 2 months ago (2015-09-28 08:06:07 UTC) #2
Michael Starzinger
Looking good modulo the next-script-id we discussed. https://codereview.chromium.org/1371893002/diff/1/src/heap/heap.h File src/heap/heap.h (right): https://codereview.chromium.org/1371893002/diff/1/src/heap/heap.h#newcode2308 src/heap/heap.h:2308: int last_script_id_; ...
5 years, 2 months ago (2015-09-28 12:01:37 UTC) #3
Jakob Kummerow
New patch set uploaded. (It also contains a rebase, sorry, because I was switching machines.)
5 years, 2 months ago (2015-09-28 12:16:35 UTC) #4
Michael Starzinger
LGTM.
5 years, 2 months ago (2015-09-28 12:24:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371893002/20001
5 years, 2 months ago (2015-09-28 12:26:54 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/6140)
5 years, 2 months ago (2015-09-28 12:34:25 UTC) #9
mvstanton
debug.cc: lgtm
5 years, 2 months ago (2015-09-28 12:51:29 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1371893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1371893002/20001
5 years, 2 months ago (2015-09-28 12:53:44 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-28 13:10:22 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 13:10:38 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/7117acd26c04c7bcfda20d8f55b7e5ec8418439c
Cr-Commit-Position: refs/heads/master@{#30975}

Powered by Google App Engine
This is Rietveld 408576698