Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: src/debug/debug.cc

Issue 1371893002: objects-inl.h: Remove ACCESSORS_TO_SMI macro (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: undo last_script_id storage change Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/d8.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 5dc1742137b5942daf64f3eeca772bf97c59cdf9..4f23555d28f59c376b13c35071d3ca47a1e3a683 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -690,8 +690,8 @@ void Debug::ClearBreakPoint(Handle<Object> break_point_object) {
Handle<DebugInfo> debug_info = node->debug_info();
// Find the break point and clear it.
- Address pc = debug_info->code()->entry() +
- break_point_info->code_position()->value();
+ Address pc =
+ debug_info->code()->entry() + break_point_info->code_position();
BreakLocation location =
BreakLocation::FromAddress(debug_info, ALL_BREAK_LOCATIONS, pc);
@@ -1071,10 +1071,10 @@ Handle<Object> Debug::GetSourceBreakLocations(
Smi* position = NULL;
switch (position_alignment) {
case STATEMENT_ALIGNED:
- position = break_point_info->statement_position();
+ position = Smi::FromInt(break_point_info->statement_position());
break;
case BREAK_POSITION_ALIGNED:
- position = break_point_info->source_position();
+ position = Smi::FromInt(break_point_info->source_position());
break;
}
for (int j = 0; j < break_points; ++j) locations->set(count++, position);
@@ -1678,7 +1678,7 @@ void Debug::RecordEvalCaller(Handle<Script> script) {
Code* code = it.frame()->LookupCode();
int offset = static_cast<int>(
it.frame()->pc() - code->instruction_start());
- script->set_eval_from_instructions_offset(Smi::FromInt(offset));
+ script->set_eval_from_instructions_offset(offset);
}
}
« no previous file with comments | « src/d8.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698