Make aidl.py create .srcjars with .java files in package-based directories

Make aidl.py create .srcjars with .java files in package-based directories

They were previously created not within any subdirectory. Having them
within subdirectories is a prereq. for incremental compilation.

BUG=536817
Committed: https://crrev.com/0c4d49e5e801760dfbd30b58f3e92c2c327bbc69
Cr-Commit-Position: refs/heads/master@{#351404}

[agrieve, 2015-09-29 13:43:59]

agrieve@chromium.org changed reviewers:
+ yfriedman@chromium.org

[agrieve, 2015-09-29 13:44:03]

On 2015/09/29 13:43:59, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:yfriedman@chromium.org

[agrieve, 2015-09-29 17:20:14]

On 2015/09/29 13:44:03, agrieve wrote:
> On 2015/09/29 13:43:59, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:yfriedman@chromium.org

♞

[Yaron, 2015-09-29 17:24:05]

https://codereview.chromium.org/1371403002/diff/1/build/android/gyp/aidl.py
File build/android/gyp/aidl.py (right):

https://codereview.chromium.org/1371403002/diff/1/build/android/gyp/aidl.py#n...
build/android/gyp/aidl.py:47: with zipfile.ZipFile(options.srcjar, 'w') as
srcjar:
As an alternative, how hard would it be to create them in the correct subdir?
The current setup also makes things like eclipse sad because the package doesn't
match the directory

[agrieve, 2015-09-29 17:36:56]

https://codereview.chromium.org/1371403002/diff/1/build/android/gyp/aidl.py
File build/android/gyp/aidl.py (right):

https://codereview.chromium.org/1371403002/diff/1/build/android/gyp/aidl.py#n...
build/android/gyp/aidl.py:47: with zipfile.ZipFile(options.srcjar, 'w') as
srcjar:
On 2015/09/29 17:24:05, Yaron wrote:
> As an alternative, how hard would it be to create them in the correct subdir?
> The current setup also makes things like eclipse sad because the package
doesn't
> match the directory

The .java files are deleted after the script runs, so this does fully fix the
issue.

[Yaron, 2015-09-29 17:48:00]

lgtm

https://codereview.chromium.org/1371403002/diff/1/build/android/gyp/aidl.py
File build/android/gyp/aidl.py (right):

https://codereview.chromium.org/1371403002/diff/1/build/android/gyp/aidl.py#n...
build/android/gyp/aidl.py:47: with zipfile.ZipFile(options.srcjar, 'w') as
srcjar:
On 2015/09/29 17:36:56, agrieve wrote:
> On 2015/09/29 17:24:05, Yaron wrote:
> > As an alternative, how hard would it be to create them in the correct
subdir?
> > The current setup also makes things like eclipse sad because the package
> doesn't
> > match the directory
> 
> The .java files are deleted after the script runs, so this does fully fix the
> issue.

Right, thanks for clarifying the gyp vs gn thing. srcjars for eclipse classpath
seems like a legit fix

[agrieve, 2015-09-29 20:14:42]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2015-09-29 20:15:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1371403002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1371403002/1

[commit-bot: I haz the power, 2015-09-29 21:19:02]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-09-29 21:20:31]

Patchset 1 (id:??) landed as
https://crrev.com/0c4d49e5e801760dfbd30b58f3e92c2c327bbc69
Cr-Commit-Position: refs/heads/master@{#351404}