Hide the Omnibox and Tabs before the views are moved into the immersive

In Immersive Fullscreen, there is a glimpse of the omnibox and tabs at
the end of the blackout animation. To fix this issue, the omnibox and
tabs are removed at the beginning of the animation so that they won't
appear at the end of it.

BUG=531999, 527395

[spqchan, 2015-09-28 22:52:35]

spqchan@chromium.org changed reviewers:
+ avi@chromium.org

[spqchan, 2015-09-28 22:52:36]

PTAL

[Avi (use Gerrit), 2015-09-28 22:59:10]

avi@chromium.org changed reviewers:
+ erikchen@chromium.org
- avi@chromium.org

[Avi (use Gerrit), 2015-09-28 22:59:11]

OK? It's been years since I've worked in this area. Tossing to Erik.

[erikchen, 2015-10-01 20:32:45]

https://codereview.chromium.org/1371243003/diff/30002/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/1371243003/diff/30002/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:518: // Create the
fullscreen window.
Why did this get moved before the fade to black?

https://codereview.chromium.org/1371243003/diff/30002/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:535: [self
adjustUIForSlidingFullscreenStyle:style];
adjustUIForSlidingFullscreenStyle: calls layoutSubviews. That method is called
again later in this method. -layoutSubviews should instantaneously readjust the
views to be in the correct positions, so how does moving this before
"moveViewsForImmersiveFullscreen:" fix the problem?

Can you include more description in the bug about the actual nature of the
problem?

[spqchan, 2015-10-05 16:20:58]

PTAL

https://codereview.chromium.org/1371243003/diff/30002/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/browser_window_controller_private.mm (right):

https://codereview.chromium.org/1371243003/diff/30002/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:518: // Create the
fullscreen window.
On 2015/10/01 20:32:45, erikchen wrote:
> Why did this get moved before the fade to black?

I'm want to reduce the amount of work that gets done when the screen black outs.
This snippet doesn't cause any visible changes. Although, I don't think moving 
it here actually make a difference, because there's very little work involved.

https://codereview.chromium.org/1371243003/diff/30002/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/browser_window_controller_private.mm:535: [self
adjustUIForSlidingFullscreenStyle:style];
On 2015/10/01 20:32:45, erikchen wrote:
> adjustUIForSlidingFullscreenStyle: calls layoutSubviews. That method is called
> again later in this method. -layoutSubviews should instantaneously readjust
the
> views to be in the correct positions, so how does moving this before
> "moveViewsForImmersiveFullscreen:" fix the problem?
> 
> Can you include more description in the bug about the actual nature of the
> problem?

I updated the description.

The problem is that you could see a glimpse of the tabs after the animation is
finished. Moving this solves the problem because we are hiding the tabs at the
beginning of the animation.