Hide the Omnibox and Tabs before the views are moved into the immersive

chrome/browser/ui/cocoa/browser_window_controller_private.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/browser_window_controller_private.h"
 
 #include <cmath>
 
 #include "base/command_line.h"
 #include "base/mac/bind_objc_block.h"
@@ skipping 497 matching lines @@
                                                                  style:style];
 }
 
 - (void)enterImmersiveFullscreen {
   RecordFullscreenWindowLocation([self window]);
   RecordFullscreenStyle(IMMERSIVE_FULLSCREEN);
 
   // Set to NO by |-windowDidEnterFullScreen:|.
   enteringImmersiveFullscreen_ = YES;
 
+  // Create the fullscreen window.

[erikchen, 2015/10/01 20:32:45]

Why did this get moved before the fade to black?

[spqchan, 2015/10/05 16:20:57]

I'm want to reduce the amount of work that gets done when the screen black outs.
This snippet doesn't cause any visible changes. Although, I don't think moving 
it here actually make a difference, because there's very little work involved.

+  fullscreenWindow_.reset([[self createFullscreenWindow] retain]);
+  savedRegularWindow_ = [[self window] retain];
+  savedRegularWindowFrame_ = [savedRegularWindow_ frame];
+
   // Fade to black.
   const CGDisplayReservationInterval kFadeDurationSeconds = 0.6;
   Boolean didFadeOut = NO;
   CGDisplayFadeReservationToken token;
   if (CGAcquireDisplayFadeReservation(kFadeDurationSeconds, &token)
       == kCGErrorSuccess) {
     didFadeOut = YES;
     CGDisplayFade(token, kFadeDurationSeconds / 2, kCGDisplayBlendNormal,
         kCGDisplayBlendSolidColor, 0.0, 0.0, 0.0, /*synchronous=*/true);
   }
 
-  // Create the fullscreen window.
-  fullscreenWindow_.reset([[self createFullscreenWindow] retain]);
-  savedRegularWindow_ = [[self window] retain];
-  savedRegularWindowFrame_ = [savedRegularWindow_ frame];
+  fullscreen_mac::SlidingStyle style = fullscreen_mac::OMNIBOX_TABS_NONE;
+  [self adjustUIForSlidingFullscreenStyle:style];

[erikchen, 2015/10/01 20:32:45]

adjustUIForSlidingFullscreenStyle: calls layoutSubviews. That method is called
again later in this method. -layoutSubviews should instantaneously readjust the
views to be in the correct positions, so how does moving this before
"moveViewsForImmersiveFullscreen:" fix the problem?

Can you include more description in the bug about the actual nature of the
problem?

[spqchan, 2015/10/05 16:20:58]

I updated the description.

The problem is that you could see a glimpse of the tabs after the animation is
finished. Moving this solves the problem because we are hiding the tabs at the
beginning of the animation.

 
   [self moveViewsForImmersiveFullscreen:YES
                           regularWindow:[self window]
                        fullscreenWindow:fullscreenWindow_.get()];
 
-  fullscreen_mac::SlidingStyle style = fullscreen_mac::OMNIBOX_TABS_NONE;
-  [self adjustUIForSlidingFullscreenStyle:style];
-
   // AppKit is helpful and prevents NSWindows from having the same height as
   // the screen while the menu bar is showing. This only applies to windows on
   // a secondary screen, in a separate space. Calling [NSWindow
   // setFrame:display:] with the screen's height will always reduce the
   // height by the height of the MenuBar. Calling the method with any other
   // height works fine. The relevant method in the 10.10 AppKit SDK is called:
   // _canAdjustSizeForScreensHaveSeparateSpacesIfFillingSecondaryScreen
   //
   // TODO(erikchen): Refactor the logic to allow the window to be shown after
   // the menubar has been hidden. This would remove the need for this hack.
@@ skipping 606 matching lines @@
   return browser_->tab_strip_model()->GetActiveWebContents();
 }
 
 - (PermissionBubbleManager*)permissionBubbleManager {
   if (WebContents* contents = [self webContents])
     return PermissionBubbleManager::FromWebContents(contents);
   return nil;
 }
 
 @end  // @implementation BrowserWindowController(Private)