Hide the Omnibox and Tabs before the views are moved into the immersive

chrome/browser/ui/cocoa/browser_window_controller_private.mm

Index: chrome/browser/ui/cocoa/browser_window_controller_private.mm
diff --git a/chrome/browser/ui/cocoa/browser_window_controller_private.mm b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
index 99ef304ce6729e554005c42a8fe0fa3db73f2f27..91d9e1be336f9b423fdad9d9e381968947a10300 100644
--- a/chrome/browser/ui/cocoa/browser_window_controller_private.mm
+++ b/chrome/browser/ui/cocoa/browser_window_controller_private.mm
@@ -515,6 +515,11 @@ willPositionSheet:(NSWindow*)sheet
   // Set to NO by |-windowDidEnterFullScreen:|.
   enteringImmersiveFullscreen_ = YES;
 
+  // Create the fullscreen window.

[erikchen, 2015/10/01 20:32:45]

Why did this get moved before the fade to black?

[spqchan, 2015/10/05 16:20:57]

I'm want to reduce the amount of work that gets done when the screen black outs.
This snippet doesn't cause any visible changes. Although, I don't think moving 
it here actually make a difference, because there's very little work involved.

+  fullscreenWindow_.reset([[self createFullscreenWindow] retain]);
+  savedRegularWindow_ = [[self window] retain];
+  savedRegularWindowFrame_ = [savedRegularWindow_ frame];
+
   // Fade to black.
   const CGDisplayReservationInterval kFadeDurationSeconds = 0.6;
   Boolean didFadeOut = NO;
@@ -526,18 +531,13 @@ willPositionSheet:(NSWindow*)sheet
         kCGDisplayBlendSolidColor, 0.0, 0.0, 0.0, /*synchronous=*/true);
   }
 
-  // Create the fullscreen window.
-  fullscreenWindow_.reset([[self createFullscreenWindow] retain]);
-  savedRegularWindow_ = [[self window] retain];
-  savedRegularWindowFrame_ = [savedRegularWindow_ frame];
+  fullscreen_mac::SlidingStyle style = fullscreen_mac::OMNIBOX_TABS_NONE;
+  [self adjustUIForSlidingFullscreenStyle:style];

[erikchen, 2015/10/01 20:32:45]

adjustUIForSlidingFullscreenStyle: calls layoutSubviews. That method is called
again later in this method. -layoutSubviews should instantaneously readjust the
views to be in the correct positions, so how does moving this before
"moveViewsForImmersiveFullscreen:" fix the problem?

Can you include more description in the bug about the actual nature of the
problem?

[spqchan, 2015/10/05 16:20:58]

I updated the description.

The problem is that you could see a glimpse of the tabs after the animation is
finished. Moving this solves the problem because we are hiding the tabs at the
beginning of the animation.

 
   [self moveViewsForImmersiveFullscreen:YES
                           regularWindow:[self window]
                        fullscreenWindow:fullscreenWindow_.get()];
 
-  fullscreen_mac::SlidingStyle style = fullscreen_mac::OMNIBOX_TABS_NONE;
-  [self adjustUIForSlidingFullscreenStyle:style];
-
   // AppKit is helpful and prevents NSWindows from having the same height as
   // the screen while the menu bar is showing. This only applies to windows on
   // a secondary screen, in a separate space. Calling [NSWindow