Chromium Code Reviews Chromium Code Reviews
Issue
1370963002:
Mac: Don't CHECK that AcquireIOSurface succeeds (Closed)
DescriptionMac: Don't CHECK that AcquireIOSurface succeeds
This became the top renderer crasher. Allow the call to return failure.
BUG=532149
Review URL: https://codereview.chromium.org/1352913003
Cr-Commit-Position: refs/heads/master@{#349963}
(cherry picked from commit 7334a8be2b4e2c0b7b6b2732af490159e6dc480b)
Mac: Ensure that Mach messages always get a reply
It may be that not getting replies from Mach messages was causing the
renderer to hang (appearing as a persistent blank white screen).
In particular, we send IOSurface Register and Acquire functions with the
flags MACH_SEND_MSG | MACH_RCV_MSG, but, if the browser doesn't
understand the request, it never sends the message back to the renderer,
so the receive part hangs forever.
Add a flag containing the result of the browser's operation, and, if
the renderer would not have gotten a message back (and would have hung),
just crash the renderer.
BUG=532149
Review URL: https://codereview.chromium.org/1351753002
Cr-Commit-Position: refs/heads/master@{#349743}
(cherry picked from commit 7c766ff43c0b84fb97e2a58c3be183c3d1339f23)
Committed: https://chromium.googlesource.com/chromium/src/+/08aa887664554c153c2825994dda492ae5b1e0ba
Patch Set 1 #
Messages
Total messages: 1 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
