Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 1352913003: Mac: Don't CHECK that AcquireIOSurface succeeds (Closed)

Created:
5 years, 3 months ago by ccameron
Modified:
5 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Mac: Don't CHECK that AcquireIOSurface succeeds This became the top renderer crasher. Allow the call to return failure. BUG=532149 Committed: https://crrev.com/7334a8be2b4e2c0b7b6b2732af490159e6dc480b Cr-Commit-Position: refs/heads/master@{#349963}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M content/child/child_io_surface_manager_mac.cc View 1 chunk +4 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
ccameron
5 years, 3 months ago (2015-09-21 05:17:35 UTC) #2
reveman
lgtm
5 years, 3 months ago (2015-09-21 15:29:35 UTC) #3
ccameron
Adding avi@ as OWNER
5 years, 3 months ago (2015-09-21 17:02:41 UTC) #4
ccameron
Adding avi@ as OWNER
5 years, 3 months ago (2015-09-21 17:03:00 UTC) #6
Avi (use Gerrit)
lgtm
5 years, 3 months ago (2015-09-21 17:32:29 UTC) #7
ccameron
Thanks!
5 years, 3 months ago (2015-09-21 17:33:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1352913003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1352913003/1
5 years, 3 months ago (2015-09-21 17:33:56 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 18:01:18 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 18:01:54 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7334a8be2b4e2c0b7b6b2732af490159e6dc480b
Cr-Commit-Position: refs/heads/master@{#349963}

Powered by Google App Engine
This is Rietveld 408576698