Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Unified Diff: content/child/child_io_surface_manager_mac.cc

Issue 1370963002: Mac: Don't CHECK that AcquireIOSurface succeeds (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2490
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/child/child_io_surface_manager_mac.cc
diff --git a/content/child/child_io_surface_manager_mac.cc b/content/child/child_io_surface_manager_mac.cc
index 65df72b04aa034053d80a292362a0c234f574884..2f711815e4daef6803c8a3b8c96f2e2e8a7f6690 100644
--- a/content/child/child_io_surface_manager_mac.cc
+++ b/content/child/child_io_surface_manager_mac.cc
@@ -134,6 +134,10 @@ IOSurfaceRef ChildIOSurfaceManager::AcquireIOSurface(
MACH_LOG(ERROR, kr) << "mach_msg";
return nullptr;
}
+ if (!data.reply.msg.result) {
+ DLOG(ERROR) << "Browser refused AcquireIOSurface request";
+ return nullptr;
+ }
// Deallocate the right after creating an IOSurface reference.
base::mac::ScopedMachSendRight scoped_io_surface_right(
« no previous file with comments | « content/browser/browser_io_surface_manager_mac_unittest.cc ('k') | content/common/mac/io_surface_manager_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698