build/config/clang/BUILD.gn - Issue 1370923002: Enforce marking "override" for functions overriding Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/clang/BUILD.gn

Issue 1370923002: Enforce marking "override" for functions overriding Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: missed one Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/clang/BUILD.gn

diff --git a/build/config/clang/BUILD.gn b/build/config/clang/BUILD.gn

index 02c5f2ca9425d5f2d9230f769a265c578fc9a0e3..e5604314a2431f788168a8f19a96ea663dd9b597 100644

--- a/build/config/clang/BUILD.gn

+++ b/build/config/clang/BUILD.gn

@@ -40,6 +40,10 @@ config("find_bad_constructs") {

"-plugin-arg-find-bad-constructs",

"-Xclang",

"check-templates",

+ "-Xclang",

+ "-plugin-arg-find-bad-constructs",

+ "-Xclang",

+ "enforce-overriding-blink",

]

}

« no previous file with comments | « build/common.gypi ('k') | cc/blink/web_scroll_offset_animation_curve_impl.h » ('j') | no next file with comments »