Use FRIEND_TEST_ALL_PREFIXES instead of FRIEND_TEST.

Use FRIEND_TEST_ALL_PREFIXES instead of FRIEND_TEST.

Also remove a custom FRIEND_TEST_ALL_PREFIXES #define from 6 years ago.

Committed: https://crrev.com/47175a76a68bf6087d3eef3d7a1210da4441a52e
Cr-Commit-Position: refs/heads/master@{#350719}

[Lei Zhang, 2015-09-24 21:29:56]

thestig@chromium.org changed reviewers:
+ zea@chromium.org

[Lei Zhang, 2015-09-24 21:29:57]

zea: Please review the CL
derat: FYI

FTR, https://codereview.chromium.org/546100 added the duplicate
FRIEND_TEST_ALL_PREFIXES. Just not seen what makes it so special.

[Nicolas Zea, 2015-09-24 21:36:35]

lgtm

https://codereview.chromium.org/1370563002/diff/1/jingle/notifier/base/xmpp_c...
File jingle/notifier/base/xmpp_connection.h (right):

https://codereview.chromium.org/1370563002/diff/1/jingle/notifier/base/xmpp_c...
jingle/notifier/base/xmpp_connection.h:25: }
nit: // namespace buzz?

[Daniel Erat, 2015-09-24 21:36:43]

derat@chromium.org changed reviewers:
+ derat@chromium.org

[Daniel Erat, 2015-09-24 21:36:44]

wow, uh... five years ago.

i think that we create a symlink now when we build this for chrome os and brillo
to work around this. if not, we'll come up with something the next time the
chrome os package gets updated.

[Lei Zhang, 2015-09-24 21:37:55]

https://codereview.chromium.org/1370563002/diff/1/jingle/notifier/base/xmpp_c...
File jingle/notifier/base/xmpp_connection.h (right):

https://codereview.chromium.org/1370563002/diff/1/jingle/notifier/base/xmpp_c...
jingle/notifier/base/xmpp_connection.h:25: }
On 2015/09/24 21:36:35, Nicolas Zea wrote:
> nit: // namespace buzz?

Sure. I'm meh about the closing comment when it's only a few lines.

[Lei Zhang, 2015-09-24 21:38:24]

On 2015/09/24 21:36:44, Daniel Erat wrote:
> wow, uh... five years ago.
> 
> i think that we create a symlink now when we build this for chrome os and
brillo
> to work around this. if not, we'll come up with something the next time the
> chrome os package gets updated.

Ok, will CQ this in a sec. Hope it won't cause too much trouble.

[Lei Zhang, 2015-09-24 21:39:59]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2015-09-24 21:39:59]

The patchset sent to the CQ was uploaded after l-g-t-m from zea@chromium.org
Link to the patchset: https://codereview.chromium.org/1370563002/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2015-09-24 21:41:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1370563002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1370563002/20001

[commit-bot: I haz the power, 2015-09-25 00:22:10]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-25 00:23:06]

Patchset 2 (id:??) landed as
https://crrev.com/47175a76a68bf6087d3eef3d7a1210da4441a52e
Cr-Commit-Position: refs/heads/master@{#350719}