Remove gtest_prod.h include from JSONReader.

Remove gtest_prod.h include from JSONReader.

I'd like to build this code for Chrome OS, but the gtest
include path is different there.  I'm removing the include
and adding the FRIEND_TEST() macro directly to json_reader.h.

BUG=none
TEST=compiled

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36775

[Daniel Erat, 2010-01-21 02:09:37]

The DISABLE_GTEST name was chosen arbitrarily; let me know if you think it's too
hacky or if it should be DISABLE_GTEST_FOR_CHROME_OS or something.

[tony, 2010-01-21 02:13:13]

http://codereview.chromium.org/546100/diff/1/2
File base/json/json_reader.h (right):

http://codereview.chromium.org/546100/diff/1/2#newcode133
base/json/json_reader.h:133: FRIEND_TEST(JSONReaderTest, Reading);
Can you remove the header completely and just change this to:
friend class JSONReaderTest?

[Evan Martin, 2010-01-21 02:26:52]

http://codereview.chromium.org/546100/diff/1/2
File base/json/json_reader.h (right):

http://codereview.chromium.org/546100/diff/1/2#newcode133
base/json/json_reader.h:133: FRIEND_TEST(JSONReaderTest, Reading);
On 2010/01/21 02:13:13, tony wrote:
> Can you remove the header completely and just change this to:
> friend class JSONReaderTest?

yeah, that's what I was suggesting too.  Maybe put in a comment about why not to
use FRIEND_TEST

[Daniel Erat, 2010-01-21 18:20:02]

On 2010/01/21 02:26:52, Evan Martin wrote:
> http://codereview.chromium.org/546100/diff/1/2
> File base/json/json_reader.h (right):
> 
> http://codereview.chromium.org/546100/diff/1/2#newcode133
> base/json/json_reader.h:133: FRIEND_TEST(JSONReaderTest, Reading);
> On 2010/01/21 02:13:13, tony wrote:
> > Can you remove the header completely and just change this to:
> > friend class JSONReaderTest?
> 
> yeah, that's what I was suggesting too.  Maybe put in a comment about why not
to
> use FRIEND_TEST

That'd be nice, but I think that friendship with a base class doesn't imply
friendship with its derived classes (hence FRIEND_TEST() existing).  I've axed
the include and pasted in the FRIEND_TEST() macro -- another look?

[Evan Martin, 2010-01-21 18:43:51]

LGTM