Issue 1366123002: Cleanup: IWYU for base/gtest_prod_util.h.

Issue 1366123002: Cleanup: IWYU for base/gtest_prod_util.h. (Closed)

Created:
5 years, 3 months ago by Lei Zhang

Modified:
5 years, 2 months ago

Reviewers:
brettw, pneubeck (no reviews)

CC:
chromium-reviews, sadrul, hcarmona+bubble_chromium.org, johnme+watch_chromium.org, nasko+codewatch_chromium.org, dcheng, ben+mojo_chromium.org, tim+watch_chromium.org, melevin+watch_chromium.org, pvalenzuela+watch_chromium.org, kalyank, mlamouri+watch-content_chromium.org, derat+watch_chromium.org, jianli, media-router+watch_chromium.org, mlamouri+watch-permissions_chromium.org, tfarina, mvanouwerkerk+watch_chromium.org, plaree+watch_chromium.org, estade+watch_chromium.org, mmenke, donnd+watch_chromium.org, viettrungluu+watch_chromium.org, dougw+watch_chromium.org, sievers+watch_chromium.org, bondd+autofillwatch_chromium.org, noyau+watch_chromium.org, kinuko+watch, wjmaclean, mlamouri+watch-geolocation_chromium.org, jam, chromium-apps-reviews_chromium.org, jennb, creis+watch_chromium.org, jsbell+serviceworker_chromium.org, nhiroki, Michael van Ouwerkerk, Jered, michaelpg+watch-options_chromium.org, serviceworker-reviews, samarth+watch_chromium.org, horo+watch_chromium.org, peter+watch_chromium.org, David Black, zea+watch_chromium.org, dhollowa+watch_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, dgrogan, tracing+reviews_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, msw+watch_chromium.org, chromoting-reviews_chromium.org, abarth-chromium, darin-cc_chromium.org, blink-worker-reviews_chromium.org, pedrosimonetti+watch_chromium.org, dbeam+watch-ntp_chromium.org, rouslan+autofill_chromium.org, jfweitz+watch_chromium.org, oshima+watch_chromium.org, piman+watch_chromium.org, rouslan+bubble_chromium.org, groby+bubble_chromium.org, wfh+watch_chromium.org, maxbogue+watch_chromium.org, Aaron Boodman, cmumford, Paweł Hajdan Jr., James Su, davemoore+watch_chromium.org, skanuj+watch_chromium.org, felt, qsr+mojo_chromium.org, tzik, posciak+watch_chromium.org, mcasas+watch_chromium.org, cbentzel+watch_chromium.org, grt+watch_chromium.org, jbauman+watch_chromium.org, dbeam+watch-options_chromium.org, mlamouri+watch-notifications_chromium.org, feature-media-reviews_chromium.org, kmadhusu+watch_chromium.org, jsbell+idb_chromium.org, darin (slow to review), michaeln, Dmitry Titov, jdonnelly+autofillwatch_chromium.org, kinuko+serviceworker, mkwst+moarreviews-renderer_chromium.org, danakj+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@gtest_iwyu

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup: IWYU for base/gtest_prod_util.h. CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=pneubeck@chromium.org Committed: https://crrev.com/a0e18cd977a07253976834dadb8d08a2d5630460 Cr-Commit-Position: refs/heads/master@{#350770}

Patch Set 1 : Add #include for files that use FRIEND_TEST_ALL_PREFIXES, fix push_messaging_permission_context.h #

Patch Set 2 : Remove #include for files that do not #

Patch Set 3 : Fix the oddball #

Patch Set 4 : lint: header guards, explicit #

Patch Set 5 : more lint, non-trivial in workspace_window_resizer.cc #

Patch Set 6 : more lint #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+167 lines, -189 lines)			Patch
M	ash/display/unified_mouse_warp_controller.h	View	1 2 3	2 chunks	+3 lines, -4 lines	0 comments	Download
M	ash/shelf/shelf_layout_manager.h	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download
M	ash/system/tray_accessibility.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/touch/touch_transformer_controller.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ash/wm/dock/docked_window_layout_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.h	View	1 2 3 4	3 chunks	+4 lines, -5 lines	0 comments	Download
M	ash/wm/workspace/workspace_window_resizer.cc	View	1 2 3 4	3 chunks	+8 lines, -8 lines	0 comments	Download
M	base/memory/memory_pressure_monitor_chromeos.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/metrics/bucket_ranges.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	base/trace_event/trace_event_impl.h	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	base/trace_event/trace_log.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	cc/scheduler/begin_frame_source_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chrome_content_browser_client.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/extensions/external_cache.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/file_system_provider/service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/chromeos/mobile/mobile_activator.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/engagement/site_engagement_service.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/activity_log/activity_log.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/activity_log/counting_policy.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/braille_display_private/braille_controller_brlapi.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/api/content_settings/content_settings_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/identity/identity_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/api/system_indicator/system_indicator_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/background_app_browsertest.cc	View	1 2 3 4	2 chunks	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_sync_data.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/extension_sync_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/pending_extension_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/token_cache/token_cache_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/updater/extension_updater.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/webstore_installer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/extensions/webstore_startup_installer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/geolocation/geolocation_permission_context_unittest.cc	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/image_holder.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/media/router/media_route.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/media/router/media_router_mojo_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/memory/tab_manager_delegate_chromeos.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/message_center_notification_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_permission_context.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/notifications/notification_permission_context_unittest.cc	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/predictors/autocomplete_action_predictor.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/predictors/resource_prefetcher.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/prerender/prerender_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/off_the_record_profile_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/profiles/profile_info_cache.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/push_messaging/push_messaging_permission_context.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/safe_browsing/local_database_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/safe_browsing/protocol_manager_helper.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sessions/session_service.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/sessions/session_service_factory.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/signin/mutable_profile_oauth2_token_service_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ssl/ssl_error_classification.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/status_icons/status_tray.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/supervised_user/legacy/supervised_user_registration_utility.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/tracing/crash_service_uploader.h	View	1 2 3 4 5	2 chunks	+0 lines, -8 lines	0 comments	Download
M	chrome/browser/tracing/crash_service_uploader.cc	View	1 2 3 4 5	1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/app_list/extension_app_model_builder.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/browser_instant_controller_unittest.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/autofill/new_credit_card_bubble_cocoa_unittest.mm	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/selected_keyword_decoration.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/panels/panel_cocoa.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/screen_capture_notification_ui_cocoa.h	View	1 2 3	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/ui/libgtk2ui/x11_input_method_context_impl_gtk2.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/panels/panel.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/apps/app_info_dialog/app_info_permissions_panel.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/apps/chrome_native_app_window_views_aura.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bar_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_editor_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/extensions/media_galleries_dialog_views.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/frame/web_app_left_header_view_ash.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_result_view.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/status_icons/status_tray_win.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/tabs/tab_strip.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/views/toolbar/reload_button.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/translate/translate_bubble_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/media_router/media_router_dialog_controller_impl.h	View	1 2 3 4 5	2 chunks	+1 line, -4 lines	0 comments	Download
M	chrome/browser/ui/webui/ntp/new_tab_page_sync_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/options/autofill_options_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview/print_preview_handler.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/signin/inline_login_handler_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/upgrade_detector.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/common/extensions/permissions/chrome_permission_message_provider.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/common/partial_circular_buffer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/installer/util/google_chrome_distribution.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/renderer/chrome_content_renderer_client.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/renderer/content_settings_observer.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/service/service_process.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	chromeos/network/network_configuration_handler.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	cloud_print/gcp20/prototype/printer.h	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	components/audio_modem/audio_recorder.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/content/renderer/autofill_agent.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/content/renderer/password_autofill_agent.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/autocomplete_history_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/contact_info.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/credit_card_field.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/autofill/core/browser/personal_data_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/core/browser/phone_field.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/autofill/core/browser/phone_number.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/component_updater/component_updater_service.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_bypass_stats.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/data_reduction_proxy/core/browser/data_reduction_proxy_tamper_detection.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/data_reduction_proxy/core/common/data_reduction_proxy_event_store.h	View	1 2 3	2 chunks	+1 line, -2 lines	0 comments	Download
M	components/enhanced_bookmarks/enhanced_bookmark_model.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/guest_view/browser/guest_view_manager.h	View	1 2 3 4	2 chunks	+5 lines, -5 lines	0 comments	Download
M	components/guest_view/browser/test_guest_view_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/history/core/browser/top_sites.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/metrics/serialization/metric_sample.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/omnibox/browser/autocomplete_input.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/omnibox/browser/autocomplete_provider.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox/browser/base_search_provider.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox/browser/bookmark_provider.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox/browser/history_quick_provider.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox/browser/history_url_provider.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox/browser/omnibox_field_trial.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/omnibox/browser/omnibox_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/omnibox/browser/scored_history_match.h	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	components/omnibox/browser/search_provider.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/password_manager/core/browser/password_autofill_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/sessions/core/base_session_service.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/signin/core/browser/account_reconcilor.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/signin/core/browser/refresh_token_annotation_request.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/signin/core/browser/signin_manager_base.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/signin/ios/browser/profile_oauth2_token_service_ios_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/suggestions/image_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/sync_driver/favicon_cache.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/sync_driver/tab_node_pool.h	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	components/syncable_prefs/pref_model_associator.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/translate/core/browser/translate_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/ui/zoom/zoom_controller.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/variations/variations_request_scheduler_mobile.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	components/variations/variations_seed_simulator.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/wallpaper/wallpaper_manager_base.h	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	components/web_resource/notification_promo.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/appcache/appcache_quota_client.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/cache_storage/cache_storage_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/compositor/delegated_frame_host.h	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/browser/frame_host/frame_tree.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/gpu/gpu_data_manager_impl_private.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_factory_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/indexed_db/indexed_db_transaction.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/notifications/platform_notification_context_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/media/audio_input_renderer_host.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/render_view_host_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_disk_cache_migrator.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/service_worker/service_worker_provider_host.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/service_worker/service_worker_registration.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/service_worker/service_worker_write_to_cache_job.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/storage_partition_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/browser/web_contents/aura/overscroll_window_animation.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/browser/web_contents/aura/overscroll_window_delegate.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/child/thread_safe_sender.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/public/browser/download_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/input/input_handler_proxy.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/media/aec_dump_message_filter.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/media/media_stream_audio_processor.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/renderer/media/media_stream_video_capturer_source.h	View	1 2 3 4	1 chunk	+1 line, -2 lines	0 comments	Download
M	content/renderer/pepper/host_var_tracker.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/browser/api/cast_channel/cast_channel_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/browser/api/declarative/rules_registry.h	View	1 2 3 4 5	2 chunks	+1 line, -2 lines	0 comments	Download
M	extensions/browser/api/declarative/rules_registry.cc	View	1 2 3 4 5	1 chunk	+1 line, -1 line	0 comments	Download
M	extensions/browser/api/sockets_tcp/sockets_tcp_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/browser/api/sockets_udp/sockets_udp_api.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	extensions/browser/image_loader.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	extensions/renderer/dispatcher.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	google_apis/gaia/oauth2_api_call_flow.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	gpu/config/gpu_control_list.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/audio/android/audio_manager_android.h	View	1 2 3	2 chunks	+1 line, -2 lines	0 comments	Download
M	media/audio/virtual_audio_input_stream.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/filters/ffmpeg_demuxer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	media/renderers/audio_renderer_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/base/sdch_manager.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/disk_cache/memory/mem_entry_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/dns/dns_config_service.h	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/dns/host_resolver_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/dns/mdns_client_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/ftp/ftp_network_transaction.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/http/http_security_headers.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/http/http_server_properties_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/http/http_server_properties_manager.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	net/quic/quic_stream_factory.h	View	1 2 3 4	3 chunks	+4 lines, -4 lines	0 comments	Download
M	net/socket/socks5_client_socket.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/buffered_spdy_framer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/spdy_framer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/spdy/spdy_session_pool.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/ssl/client_cert_store_mac.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/ssl/client_cert_store_win.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	net/udp/udp_socket_win.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	printing/pdf_metafile_cg_mac.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/host/chromoting_host_context.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	remoting/host/pairing_registry_delegate_linux.h	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	remoting/signaling/iq_sender.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	storage/browser/fileapi/local_file_stream_writer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	storage/browser/fileapi/obfuscated_file_util.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	storage/browser/fileapi/sandbox_file_system_backend_delegate.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	storage/browser/quota/quota_database.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/internal_api/debug_info_event_listener.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/internal_api/public/attachments/attachment_downloader_impl.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/internal_api/public/attachments/attachment_uploader_impl.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/internal_api/public/attachments/task_queue.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/internal_api/public/http_bridge.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/internal_api/public/write_node.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/internal_api/sync_manager_impl.h	View	1 2 3	2 chunks	+4 lines, -3 lines	0 comments	Download
M	sync/syncable/directory_backing_store.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/util/cryptographer.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/base/win/hwnd_subclass.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/events/latency_info.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/icon_util.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/gfx/image/image.h	View	1 2 3 4 5	3 chunks	+0 lines, -9 lines	0 comments	Download
M	ui/gfx/image/image_skia_operations.h	View	1 2 3	1 chunk	+2 lines, -3 lines	0 comments	Download
M	ui/gfx/nine_image_painter.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/render_text_harfbuzz.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/gfx/render_text_mac.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/message_center/views/message_popup_collection.h	View	1 2 3 4	2 chunks	+1 line, -2 lines	0 comments	Download
M	ui/message_center/views/notification_view.h	View	1 2 3 4	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/message_center/views/notifier_settings_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/bubble/bubble_border.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/controls/button/label_button.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/controls/scroll_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	ui/views/widget/widget.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	ui/views/window/dialog_client_view.h	View	1 2 3	2 chunks	+2 lines, -1 line	0 comments	Download
M	ui/wm/core/image_grid.h	View	1 2 3	3 chunks	+2 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 1370563002 Patch 20001

Messages

Total messages: 14 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

brettw

LGTM. I checked all the files that had more diff than just -1 line. This ...

5 years, 2 months ago (2015-09-25 03:03:33 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366123002/100001

5 years, 2 months ago (2015-09-25 03:32:01 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/103709)

5 years, 2 months ago (2015-09-25 03:44:30 UTC) #7

Lei Zhang

pneubeck: TBR for trivial chromeos/network/network_configuration_handler.h change.

5 years, 2 months ago (2015-09-25 04:01:45 UTC) #9

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1366123002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1366123002/100001

5 years, 2 months ago (2015-09-25 04:03:39 UTC) #11

commit-bot: I haz the power

Patchset 6 (id:??) landed as https://crrev.com/a0e18cd977a07253976834dadb8d08a2d5630460 Cr-Commit-Position: refs/heads/master@{#350770}

5 years, 2 months ago (2015-09-25 04:59:24 UTC) #13

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages