Disallow gl[Compressed]Tex[Sub]Image2D for GL_TEXTURE_RECTANGLE_ARB

Disallow gl[Compressed]Tex[Sub]Image2D for GL_TEXTURE_RECTANGLE_ARB

An undocumented behavior of CGLTexImageIOSurface2D is that it will fail
with kCGLBadState if the bound texture has already had storage
specified, e.g, by glTexImage2D.

This is a temporary measure for immediate merge into the long-diverged
M46. This will be followed-up by breaking the |texture_target| validator
into two separate validators.

The remaining users of the |texture_target| validator are already in
use, except for a multisample framebuffer binding.

BUG=518744
Committed: https://crrev.com/69e0ad9b7976975f0b1e94a2164179ca07e4ea34
Cr-Commit-Position: refs/heads/master@{#351384}

[ccameron, 2015-09-29 03:23:43]

ccameron@chromium.org changed reviewers:
+ piman@chromium.org

[ccameron, 2015-09-29 03:23:43]

So ... we were considering cutting up the texture_target validator when we
introduced rectangle support. And ... we should have.

This is a messy-but-easy-to-merge change. I plan to follow up with the validator
split. Let me know if you'd prefer that I try to merge the (big) validator
split.

[piman, 2015-09-29 16:23:32]

Can we not expose the GL_ARB_texture_rectangle extension if we don't expose it
fully (see code in feature_info.cc)? I.e. calling it
GL_CHROMIUM_texture_rectangle instead and documenting what does work. (In truth,
exposing GL_ARB_texture_rectangle on ES is already a bit of an abuse).
If it's a problem for the merge, let's defer to the proper fix.

You have a typo, otherwise the change looks reasonable

https://codereview.chromium.org/1376633002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1376633002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:1940: if (texture->target() ==
GL_TEXTURE_RECTANGLE_ARB) {
Did you mean args.target ?

[ccameron, 2015-09-29 18:19:18]

Updated (plus tests)

https://codereview.chromium.org/1376633002/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/texture_manager.cc (right):

https://codereview.chromium.org/1376633002/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/texture_manager.cc:1940: if (texture->target() ==
GL_TEXTURE_RECTANGLE_ARB) {
On 2015/09/29 16:23:32, piman (slow to review) wrote:
> Did you mean args.target ?

Oops -- yes.

[piman, 2015-09-29 18:20:04]

lgtm

[ccameron, 2015-09-29 18:33:47]

Thanks!

[ccameron, 2015-09-29 18:33:50]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2015-09-29 18:35:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1376633002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1376633002/40001

[commit-bot: I haz the power, 2015-09-29 20:06:23]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-29 20:07:08]

Patchset 3 (id:??) landed as
https://crrev.com/69e0ad9b7976975f0b1e94a2164179ca07e4ea34
Cr-Commit-Position: refs/heads/master@{#351384}