Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1370323004: Stop calling jpeg_finish_decompress() (Closed)

Created:
5 years, 2 months ago by msarett
Modified:
5 years, 2 months ago
Reviewers:
scroggo
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Stop calling jpeg_finish_decompress() jpeg_finish_decompress() does several things: (1) Reads to the end of the image stream. (2) Calls term_src(), a client provided function that indicates we are done with the memory stream. Our current implementation of term_src() does nothing. (3) Calls jpeg_abort() which aborts the decode and cleans up some memory. I don't think we need to call this anymore. (1) seems irrelevant. It seems a little dangerous to get rid of (2), but it is fine while our implementation of term_src() does nothing. (3) We will call jpeg_destroy() on destruction of the JpegDecoderManager. This should free all the memory, making it unnecessary to call jpeg_abort() beforehand. BUG=skia:4040 Committed: https://skia.googlesource.com/skia/+/19ae315dd06b01312de8fd40b8388aae4de9f05e

Patch Set 1 #

Patch Set 2 : Adding comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -23 lines) Patch
M src/codec/SkJpegCodec.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/codec/SkJpegCodec.cpp View 3 chunks +0 lines, -20 lines 0 comments Download
M src/codec/SkJpegUtility_codec.cpp View 1 1 chunk +6 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
msarett
This has passed CodexTest running with valgrind. I think the bots will let us know ...
5 years, 2 months ago (2015-10-02 17:15:27 UTC) #1
msarett
5 years, 2 months ago (2015-10-02 17:15:40 UTC) #3
scroggo
lgtm
5 years, 2 months ago (2015-10-02 18:45:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1370323004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1370323004/20001
5 years, 2 months ago (2015-10-02 20:37:29 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-02 20:44:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/19ae315dd06b01312de8fd40b8388aae4de9f05e

Powered by Google App Engine
This is Rietveld 408576698