Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Unified Diff: src/codec/SkJpegUtility_codec.cpp

Issue 1370323004: Stop calling jpeg_finish_decompress() (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Adding comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codec/SkJpegCodec.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/codec/SkJpegUtility_codec.cpp
diff --git a/src/codec/SkJpegUtility_codec.cpp b/src/codec/SkJpegUtility_codec.cpp
index 75a562a00454f45f8f0904d2f8a055fc1f65b006..19ece5e6adf9387b1750ee91789c4f67584bf1cb 100644
--- a/src/codec/SkJpegUtility_codec.cpp
+++ b/src/codec/SkJpegUtility_codec.cpp
@@ -61,7 +61,12 @@ static void sk_skip_input_data(j_decompress_ptr dinfo, long numBytes) {
* We do not need to do anything to terminate our stream
*/
static void sk_term_source(j_decompress_ptr dinfo)
-{}
+{
+ // The current implementation of SkJpegCodec does not call
+ // jpeg_finish_decompress(), so this function is never called.
+ // If we want to modify this function to do something, we also
+ // need to modify SkJpegCodec to call jpeg_finish_decompress().
+}
/*
* Constructor for the source manager that we provide to libjpeg
« no previous file with comments | « src/codec/SkJpegCodec.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698