Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1369593002: Reland of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 3 months ago
CC:
chromium-reviews, jbudorick+watch_chromium.org, klundberg+watch_chromium.org, pkotwicz, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@incremental-script-dep
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp (patchset #1 id:1 of https://codereview.chromium.org/1369583002/ ) Reason for revert: Fixed import path and ensured "ninja all" builds locally. Original issue's description: > Revert of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp (patchset #4 id:60001 of https://codereview.chromium.org/1356873003/ ) > > Reason for revert: > broke Android build (see other messages for details). > > Original issue's description: > > CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp > > > > Added output_paths to md5_check.py since it cuts down on > > force=os.path.exists() boilder-plate (plus places that were forgetting > > it). It also improves the message printed when PRINT_MD5_DIFFS=1 is set. > > > > Added a wrapper in build_utils.py that automatically handles --depfile > > and --stamp options, which further cuts down on boilerplate in the > > clients. > > > > Removed colorama to eliminate circular dependency between build_utils > > and md5_check. > > > > BUG=533442 > > > > Committed: https://crrev.com/dea0f30983bc18874ac8c49443fb5079d4c1b798 > > Cr-Commit-Position: refs/heads/master@{#350599} > > TBR=jbudorick@chromium.org,stgao@chromium.org,agrieve@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=533442 > > Committed: https://crrev.com/1748d384c547136d059d413f5acbb1622ba548f0 > Cr-Commit-Position: refs/heads/master@{#350626} TBR=jbudorick@chromium.org,stgao@chromium.org,caitkp@chromium.org NOTRY=true BUG=533442 Committed: https://crrev.com/ca0e19488b8e75ae5546c09f89787dec580f0916 Cr-Commit-Position: refs/heads/master@{#350647}

Patch Set 1 #

Patch Set 2 : fix import path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+204 lines, -137 lines) Patch
M build/android/PRESUBMIT.py View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/android/gyp/dex.py View 1 2 chunks +83 lines, -68 lines 0 comments Download
M build/android/gyp/javac.py View 1 6 chunks +16 lines, -27 lines 0 comments Download
M build/android/gyp/proguard.py View 1 2 chunks +5 lines, -15 lines 0 comments Download
M build/android/gyp/util/build_utils.py View 1 2 chunks +44 lines, -0 lines 0 comments Download
M build/android/gyp/util/md5_check.py View 1 4 chunks +40 lines, -26 lines 0 comments Download
M build/android/gyp/util/md5_check_test.py View 1 3 chunks +15 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 5 (1 generated)
agrieve
Created Reland of CallAndRecordIfStale(): Add knownledge of output_files, depfiles, stamp
5 years, 3 months ago (2015-09-24 20:04:56 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1369593002/190001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1369593002/190001
5 years, 3 months ago (2015-09-24 20:15:45 UTC) #3
commit-bot: I haz the power
Committed patchset #2 (id:190001)
5 years, 3 months ago (2015-09-24 20:27:20 UTC) #4
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 20:29:10 UTC) #5
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ca0e19488b8e75ae5546c09f89787dec580f0916
Cr-Commit-Position: refs/heads/master@{#350647}

Powered by Google App Engine
This is Rietveld 408576698