Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1357663002: Make use of md5_check within process_resources.py (Closed)

Created:
5 years, 3 months ago by agrieve
Modified:
5 years, 2 months ago
Reviewers:
pkotwicz
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@md5-check-1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make use of md5_check within process_resources.py This stops process_resources being run unnecessarily when only java source files have changed. BUG=533442 Committed: https://crrev.com/03f85b7b1ff4f61a76630995709257968d8d7eed Cr-Commit-Position: refs/heads/master@{#350777}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : add missing strings #

Patch Set 4 : accomodate empty flag values #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -21 lines) Patch
M build/android/gyp/process_resources.py View 1 2 3 8 chunks +70 lines, -21 lines 0 comments Download

Depends on Patchset:

Issue 1369593002 Patch 190001

Messages

Total messages: 14 (5 generated)
pkotwicz
https://codereview.chromium.org/1357663002/diff/20001/build/android/gyp/process_resources.py File build/android/gyp/process_resources.py (right): https://codereview.chromium.org/1357663002/diff/20001/build/android/gyp/process_resources.py#newcode58 build/android/gyp/process_resources.py:58: '--app-as-shared-lib', Should app_as_shared_lib be part of input_strings ? https://codereview.chromium.org/1357663002/diff/20001/build/android/gyp/process_resources.py#newcode81 ...
5 years, 3 months ago (2015-09-24 20:00:29 UTC) #2
agrieve
nice catch! https://codereview.chromium.org/1357663002/diff/20001/build/android/gyp/process_resources.py File build/android/gyp/process_resources.py (right): https://codereview.chromium.org/1357663002/diff/20001/build/android/gyp/process_resources.py#newcode58 build/android/gyp/process_resources.py:58: '--app-as-shared-lib', On 2015/09/24 20:00:29, pkotwicz wrote: > ...
5 years, 3 months ago (2015-09-24 20:28:14 UTC) #3
pkotwicz
lgtm
5 years, 3 months ago (2015-09-24 20:33:34 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357663002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357663002/40001
5 years, 2 months ago (2015-09-25 02:16:22 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/64557)
5 years, 2 months ago (2015-09-25 02:40:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1357663002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1357663002/60001
5 years, 2 months ago (2015-09-25 04:14:46 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-09-25 05:31:07 UTC) #12
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/03f85b7b1ff4f61a76630995709257968d8d7eed Cr-Commit-Position: refs/heads/master@{#350777}
5 years, 2 months ago (2015-09-25 05:31:41 UTC) #13
jochen (gone - plz use gerrit)
5 years, 2 months ago (2015-09-25 07:26:55 UTC) #14
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1370643002/ by jochen@chromium.org.

The reason for reverting is: breaks compilation, e.g.
https://build.chromium.org/p/chromium/builders/Android/builds/46769/steps/com....

Powered by Google App Engine
This is Rietveld 408576698