Make use of md5_check within package_resources.py

Make use of md5_check within package_resources.py

Turns the step into a no-op when none of its real dependencies have changed
(e.g. don't re-run it when a .java file changes)

BUG=533442
Committed: https://crrev.com/cf65ca8872e6434e94a586ceb5ab51c301e56d9d
Cr-Commit-Position: refs/heads/master@{#350764}

[agrieve, 2015-09-18 15:17:32]

agrieve@chromium.org changed reviewers:
+ pkotwicz@chromium.org

[pkotwicz, 2015-09-24 19:21:36]

LGTM with nits

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
File build/android/gyp/package_resources.py (right):

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:232: ]
Nit: I think that ']' should have the same indent as 'package_command'

The examples in the style guide seem to do this.
https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation
(Though they do not explicitly say that this should be done)

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:233: if options.no_compress:
Nit: A blank line between lines 232 and 233?

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:258: 
Nit: Remove one of the blank line?

[agrieve, 2015-09-25 02:14:36]

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
File build/android/gyp/package_resources.py (right):

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:232: ]
On 2015/09/24 19:21:36, pkotwicz wrote:
> Nit: I think that ']' should have the same indent as 'package_command'
> 
> The examples in the style guide seem to do this.
> https://google-styleguide.googlecode.com/svn/trunk/pyguide.html#Indentation
> (Though they do not explicitly say that this should be done)

Done.

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:233: if options.no_compress:
On 2015/09/24 19:21:36, pkotwicz wrote:
> Nit: A blank line between lines 232 and 233?

Done.

https://codereview.chromium.org/1351033003/diff/20001/build/android/gyp/packa...
build/android/gyp/package_resources.py:258: 
On 2015/09/24 19:21:36, pkotwicz wrote:
> Nit: Remove one of the blank line?

Style guide says 2 lines between top-level definitions

[agrieve, 2015-09-25 02:15:24]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-25 02:15:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351033003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351033003/40001

[commit-bot: I haz the power, 2015-09-25 03:51:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 03:51:32]

Dry run: This issue passed the CQ dry run.

[agrieve, 2015-09-25 04:07:23]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2015-09-25 04:07:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkotwicz@chromium.org
Link to the patchset: https://codereview.chromium.org/1351033003/#ps40001
(title: "package_resources review nits")

[commit-bot: I haz the power, 2015-09-25 04:07:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1351033003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1351033003/40001

[commit-bot: I haz the power, 2015-09-25 04:12:59]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-25 04:13:59]

Patchset 3 (id:??) landed as
https://crrev.com/cf65ca8872e6434e94a586ceb5ab51c301e56d9d
Cr-Commit-Position: refs/heads/master@{#350764}