Issue 1379563004: Improve the way "consistent" works.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1379563004: Improve the way "consistent" works. (Closed)

Created:
5 years, 2 months ago by iannucci

Modified:
5 years, 2 months ago

Reviewers:
dnj, Vadim Sh., estaab, M-A Ruel, tandrii(chromium)

CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org

Base URL:
https://github.com/luci/gae.git@fix_service_bugs

Target Ref:
refs/heads/master

Project:
luci-gae

Visibility:
Public.

More Reviews

Description

Improve the way "consistent" works. This avoids the overhead of taking many many snapshots when the in-memory datastore is in full-consistency mode. R=dnj@chromium.org, estaab@chromium.org, maruel@chromium.org, tandrii@chromium.org, vadimsh@chromium.org BUG= Committed: https://github.com/luci/gae/commit/289936790287be1d4d7569d8d182a2605f4e4399

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -21 lines)			Patch
	M	impl/memory/datastore_data.go	View		8 chunks	+12 lines, -21 lines	0 comments	Download

Depends on Patchset:

Issue 1378613003 Patch 1

Dependent Patchsets:

Issue 1369353003 Patch 1

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1379563004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1379563004/1

5 years, 2 months ago (2015-09-29 19:35:34 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-09-29 19:38:03 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/289936790287be1d4d7569d8d182a2605f4e4399

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages