Mac: restore subpixel AA in the find bar when it doesn't have focus

Mac: restore subpixel AA in the find bar when it doesn't have focus

After linking to the 10.10 SDK, the text in the find bar (Cmd+F) loses
its subpixel AA when the textfield doesn't have focus.

https://developer.apple.com/library/prerelease/mac/releasenotes/AppKit/RN-AppKitOlderNotes/#10_8Layers
documents new logic for applications linked on 10.8 and higher.
Specifically, NSTextField now allows LCD font smoothing when the view is
layer-backed, but this will be disabled if AppKit can't find an opaque
ancestor view.

The findbar textfield cell isn't opaque (it has rounded corners), but
the background behind the text is always solid (even when a theme is
installed), so enabling AA is safe. In fact, this is true for all
StyledTextFieldCells, of which there are 2 (findbar and omnibox).

Share the "force-enable-AA" logic already in BlueLabelButton and
AutocompleteTextFieldCell that does this by adding
ui::ScopedCGContextSmoothFonts. Note AutocompleteTextFieldCell overrides
-[NSCell drawWithFrame:inView:] so doesn't inherit the fix from
StyledTextFieldCell.

BUG=535790
TBR=avi@chromium.org
TEST=On Mac (without a retina screen), press Cmd+F, type something, then
click the page to defocus. The text in the find bar should keep its font
smoothing.

Committed: https://crrev.com/96e79b2a53fddaac6040ca2e699c33fbdf44641c
Cr-Commit-Position: refs/heads/master@{#351022}

[tapted, 2015-09-25 02:55:17]

tapted@chromium.org changed reviewers:
+ rsesek@chromium.org

[tapted, 2015-09-25 04:33:43]

HI Robert - please take a look. (another sdk fix for m46..)

[Robert Sesek, 2015-09-25 23:00:52]

LGTM w/ nits

https://codereview.chromium.org/1368883002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/1368883002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:349:
ui::ScopedCGContextSmoothFonts lcd_smoothing;
naming: font_smoothing? (and throughout)

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
File ui/base/cocoa/scoped_cg_context_smooth_fonts.h (right):

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
ui/base/cocoa/scoped_cg_context_smooth_fonts.h:31: }  // namespace
"namespace ui"

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
File ui/base/cocoa/scoped_cg_context_smooth_fonts.mm (right):

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
ui/base/cocoa/scoped_cg_context_smooth_fonts.mm:13: CGContextRef cgContext =
static_cast<CGContextRef>([context graphicsPort]);
naming: cg_context

[tapted, 2015-09-28 03:19:57]

The CQ bit was checked by tapted@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 03:20:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368883002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368883002/40001

[commit-bot: I haz the power, 2015-09-28 04:30:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 04:30:07]

Dry run: This issue passed the CQ dry run.

[tapted, 2015-09-28 04:30:38]

tapted@chromium.org changed reviewers:
+ avi@chromium.org

[tapted, 2015-09-28 04:30:38]

+avi TBR for

** Presubmit Messages **
Missing OWNER reviewers for these files:
    ui/base/BUILD.gn
    ui/base/ui_base.gyp

(ui/OWNERS has `per-file *.gyp*=* per-file BUILD.gn=*` but.. hm. I just noticed
it doesn't actually match anything. I'll put up a CL)

https://codereview.chromium.org/1368883002/diff/20001/chrome/browser/ui/cocoa...
File chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm
(right):

https://codereview.chromium.org/1368883002/diff/20001/chrome/browser/ui/cocoa...
chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm:349:
ui::ScopedCGContextSmoothFonts lcd_smoothing;
On 2015/09/25 23:00:52, Robert Sesek wrote:
> naming: font_smoothing? (and throughout)

Done (fontSmoothing because I had by objc/C++ style-wires crossed)

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
File ui/base/cocoa/scoped_cg_context_smooth_fonts.h (right):

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
ui/base/cocoa/scoped_cg_context_smooth_fonts.h:31: }  // namespace
On 2015/09/25 23:00:52, Robert Sesek wrote:
> "namespace ui"

Done.

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
File ui/base/cocoa/scoped_cg_context_smooth_fonts.mm (right):

https://codereview.chromium.org/1368883002/diff/20001/ui/base/cocoa/scoped_cg...
ui/base/cocoa/scoped_cg_context_smooth_fonts.mm:13: CGContextRef cgContext =
static_cast<CGContextRef>([context graphicsPort]);
On 2015/09/25 23:00:52, Robert Sesek wrote:
> naming: cg_context

Done.

[tapted, 2015-09-28 04:31:16]

The CQ bit was checked by tapted@chromium.org

[tapted, 2015-09-28 04:31:17]

The patchset sent to the CQ was uploaded after l-g-t-m from rsesek@chromium.org
Link to the patchset: https://codereview.chromium.org/1368883002/#ps40001
(title: "respond to comments")

[commit-bot: I haz the power, 2015-09-28 04:32:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1368883002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1368883002/40001

[commit-bot: I haz the power, 2015-09-28 04:36:31]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-28 04:37:28]

Patchset 3 (id:??) landed as
https://crrev.com/96e79b2a53fddaac6040ca2e699c33fbdf44641c
Cr-Commit-Position: refs/heads/master@{#351022}

[Avi (use Gerrit), 2015-09-28 15:28:10]

lgtm

👍