chrome/browser/engagement/site_engagement_service_unittest.cc - Issue 1368533004: Add UMA metrics to the site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1368533004: Add UMA metrics to the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@time-on-site

Patch Set: Refactor addressing reviewer comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/engagement/site_engagement_service.cc ('K') | « chrome/browser/engagement/site_engagement_service_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service_unittest.cc

diff --git a/chrome/browser/engagement/site_engagement_service_unittest.cc b/chrome/browser/engagement/site_engagement_service_unittest.cc

index 936e2e1aa675d54b611e4b6dc5c4d2a00aec18a1..4ea42636bc2a98d66d87baf6642fed0b9618f5a9 100644

--- a/chrome/browser/engagement/site_engagement_service_unittest.cc

+++ b/chrome/browser/engagement/site_engagement_service_unittest.cc

@@ -391,21 +391,21 @@ TEST_F(SiteEngagementServiceTest, GetTotalUserInputPoints) {

EXPECT_EQ(0, service->GetScore(url2));

EXPECT_EQ(0, service->GetScore(url3));

- service->HandleUserInput(url1);

+ service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

EXPECT_DOUBLE_EQ(0.05, service->GetScore(url1));

EXPECT_DOUBLE_EQ(0.05, service->GetTotalEngagementPoints());

- service->HandleUserInput(url2);

+ service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

+ service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

EXPECT_DOUBLE_EQ(0.1, service->GetScore(url2));

EXPECT_DOUBLE_EQ(0.15, service->GetTotalEngagementPoints());

- service->HandleUserInput(url3);

+ service->HandleUserInput(url3, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

EXPECT_DOUBLE_EQ(0.05, service->GetScore(url3));

EXPECT_DOUBLE_EQ(0.2, service->GetTotalEngagementPoints());

- service->HandleUserInput(url1);

+ service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

+ service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

EXPECT_DOUBLE_EQ(0.15, service->GetScore(url1));

EXPECT_DOUBLE_EQ(0.3, service->GetTotalEngagementPoints());

}