chrome/browser/engagement/site_engagement_service_unittest.cc - Issue 1368533004: Add UMA metrics to the site engagement service.

Side by Side Diff: chrome/browser/engagement/site_engagement_service_unittest.cc

Issue 1368533004: Add UMA metrics to the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@time-on-site

Patch Set: Refactor addressing reviewer comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/engagement/site_engagement_service.cc ('K') | « chrome/browser/engagement/site_engagement_service_browsertest.cc ('k') | chrome/chrome_browser.gypi » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2015 The Chromium Authors. All rights reserved.	1 // Copyright 2015 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "base/test/simple_test_clock.h"	6 #include "base/test/simple_test_clock.h"

7 #include "base/values.h"	7 #include "base/values.h"

8 #include "chrome/browser/engagement/site_engagement_helper.h"	8 #include "chrome/browser/engagement/site_engagement_helper.h"

9 #include "chrome/browser/engagement/site_engagement_service.h"	9 #include "chrome/browser/engagement/site_engagement_service.h"

10 #include "chrome/browser/engagement/site_engagement_service_factory.h"	10 #include "chrome/browser/engagement/site_engagement_service_factory.h"

(...skipping 373 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
384	384

385 // The https and http versions of www.google.com should be separate.	385 // The https and http versions of www.google.com should be separate.

386 GURL url1("https://www.google.com/");	386 GURL url1("https://www.google.com/");

387 GURL url2("http://www.google.com/");	387 GURL url2("http://www.google.com/");

388 GURL url3("http://drive.google.com/");	388 GURL url3("http://drive.google.com/");

389	389

390 EXPECT_EQ(0, service->GetScore(url1));	390 EXPECT_EQ(0, service->GetScore(url1));

391 EXPECT_EQ(0, service->GetScore(url2));	391 EXPECT_EQ(0, service->GetScore(url2));

392 EXPECT_EQ(0, service->GetScore(url3));	392 EXPECT_EQ(0, service->GetScore(url3));

393	393

394 service->HandleUserInput(url1);	394 service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

395 EXPECT_DOUBLE_EQ(0.05, service->GetScore(url1));	395 EXPECT_DOUBLE_EQ(0.05, service->GetScore(url1));

396 EXPECT_DOUBLE_EQ(0.05, service->GetTotalEngagementPoints());	396 EXPECT_DOUBLE_EQ(0.05, service->GetTotalEngagementPoints());

397	397

398 service->HandleUserInput(url2);	398 service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

399 service->HandleUserInput(url2);	399 service->HandleUserInput(url2, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

400 EXPECT_DOUBLE_EQ(0.1, service->GetScore(url2));	400 EXPECT_DOUBLE_EQ(0.1, service->GetScore(url2));

401 EXPECT_DOUBLE_EQ(0.15, service->GetTotalEngagementPoints());	401 EXPECT_DOUBLE_EQ(0.15, service->GetTotalEngagementPoints());

402	402

403 service->HandleUserInput(url3);	403 service->HandleUserInput(url3, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

404 EXPECT_DOUBLE_EQ(0.05, service->GetScore(url3));	404 EXPECT_DOUBLE_EQ(0.05, service->GetScore(url3));

405 EXPECT_DOUBLE_EQ(0.2, service->GetTotalEngagementPoints());	405 EXPECT_DOUBLE_EQ(0.2, service->GetTotalEngagementPoints());

406	406

407 service->HandleUserInput(url1);	407 service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_KEYPRESS);

408 service->HandleUserInput(url1);	408 service->HandleUserInput(url1, SiteEngagementMetrics::ENGAGEMENT_MOUSE);

409 EXPECT_DOUBLE_EQ(0.15, service->GetScore(url1));	409 EXPECT_DOUBLE_EQ(0.15, service->GetScore(url1));

410 EXPECT_DOUBLE_EQ(0.3, service->GetTotalEngagementPoints());	410 EXPECT_DOUBLE_EQ(0.3, service->GetTotalEngagementPoints());

411 }	411 }

OLD	NEW