chrome/browser/engagement/site_engagement_service_browsertest.cc - Issue 1368533004: Add UMA metrics to the site engagement service.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/engagement/site_engagement_service_browsertest.cc

Issue 1368533004: Add UMA metrics to the site engagement service. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@time-on-site

Patch Set: Refactor addressing reviewer comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/engagement/site_engagement_service.cc ('K') | « chrome/browser/engagement/site_engagement_service.cc ('k') | chrome/browser/engagement/site_engagement_service_unittest.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/engagement/site_engagement_service_browsertest.cc

diff --git a/chrome/browser/engagement/site_engagement_service_browsertest.cc b/chrome/browser/engagement/site_engagement_service_browsertest.cc

index 7444175edecd61ddcfc89b607fdb8fe035c317fd..1545a337480890e9350a0bfd3495d83f5e2e1155 100644

--- a/chrome/browser/engagement/site_engagement_service_browsertest.cc

+++ b/chrome/browser/engagement/site_engagement_service_browsertest.cc

@@ -66,8 +66,8 @@ class TestSiteEngagementHelper : public SiteEngagementHelper {

enable_callbacks_ = false;

}

- void RecordUserInput() override {

- SiteEngagementHelper::RecordUserInput();

+ void RecordUserInput(SiteEngagementMetrics::EngagementType type) override {

+ SiteEngagementHelper::RecordUserInput(type);

FOR_EACH_OBSERVER(Observer, observer_list_, OnInputRecorded(this));

}