Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1367783002: Revert of ChildAccountService[Java] delegates everything to native side. (Closed)

Created:
5 years, 3 months ago by dcheng
Modified:
5 years, 3 months ago
Reviewers:
Bernhard Bauer, knn
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@child
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of ChildAccountService[Java] delegates everything to native side. (patchset #2 id:20001 of https://codereview.chromium.org/1341423005/ ) Reason for revert: Depends on https://codereview.chromium.org/1357643002, which is being reverted. Original issue's description: > ChildAccountService[Java] delegates everything to native side. > > Most of the child account detection/enforcement logic has been divided amongst > the ChildAccountInfoFetcher and ForcedSigninProcessor. > > ForcedSigninProcessor will make sure that child accounts are detected and > are signed in. > ChildAccountInfoFetcher only activates on signin and informs the > native ChildAccountService about the child account and takes responsiblity for > any further updates (graduation) or account changes. > > Depends on http://crrev.com/1357643002 > Dependent patchset http://crrev.com/1353393002 > > BUG=518830 > > Committed: https://crrev.com/1c628b552ba2f3619518c22f25ef983e81490831 > Cr-Commit-Position: refs/heads/master@{#350138} TBR=bauerb@chromium.org,knn@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=518830 Committed: https://chromium.googlesource.com/chromium/src/+/1a8d1e64afb2a16a38e2b2e32768ede872fa7e92

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+758 lines, -86 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/childaccounts/ChildAccountService.java View 2 chunks +293 lines, -51 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/services/AndroidEduAndChildAccountHelper.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/AccountManagementFragment.java View 6 chunks +9 lines, -8 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/signin/SigninManager.java View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/junit/src/org/chromium/chrome/browser/childaccounts/ChildAccountServiceTest.java View 1 chunk +363 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service.cc View 3 chunks +31 lines, -20 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service_android.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/supervised_user/child_accounts/child_account_service_android.cc View 1 chunk +43 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
dcheng
Created Revert of ChildAccountService[Java] delegates everything to native side.
5 years, 3 months ago (2015-09-23 23:24:16 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/1a8d1e64afb2a16a38e2b2e32768ede872fa7e92 Cr-Commit-Position: refs/heads/master@{#350388}
5 years, 3 months ago (2015-09-23 23:34:48 UTC) #3
dcheng
5 years, 3 months ago (2015-09-23 23:35:10 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1a8d1e64afb2a16a38e2b2e32768ede872fa7e92 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698