[Android]Don't check for child account/EDU device for every activity.

[Android]Don't check for child account/EDU device for every activity.

Extract a Forced Signin Processor out of FirstRun Signin Processor which
checks for child accounts and EDU device and is only triggered:
-Once per Chrome Application startup.
-On updates to accounts on the device.

Invariants:
FRE ToS checks and FRE pending signin checks still happen on every activity for now.

Dependent patchsets:
http://crrev.com/1341423005
http://crrev.com/1353393002

BUG=518830
Committed: https://crrev.com/b022082dde8822156eb2fcd3a1c156b566119521
Cr-Commit-Position: refs/heads/master@{#350133}

[knn, 2015-09-18 13:56:05]

knn@chromium.org changed reviewers:
+ bauerb@chromium.org

[knn, 2015-09-18 13:56:05]

PTAL at patchset 1.

[Bernhard Bauer, 2015-09-18 14:21:41]

Thanks for the Yak shaving! ☺

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSigninProcessor.java
(right):

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSigninProcessor.java:137:
Log.e("FirstRunSigninProcessor", "Attempt to pass-through without completed
FRE");
Extract a TAG?

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ForcedSigninProcessor.java
(right):

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ForcedSigninProcessor.java:26:
* FirstRunSigninProcessor.start(appContext).
*Forced*SigninProcessor 😀

[knn, 2015-09-21 14:11:49]

PTAL. Thanks!

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSigninProcessor.java
(right):

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSigninProcessor.java:137:
Log.e("FirstRunSigninProcessor", "Attempt to pass-through without completed
FRE");
On 2015/09/18 14:21:40, Bernhard Bauer wrote:
> Extract a TAG?

Done.

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ForcedSigninProcessor.java
(right):

https://codereview.chromium.org/1357643002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/firstrun/ForcedSigninProcessor.java:26:
* FirstRunSigninProcessor.start(appContext).
On 2015/09/18 14:21:40, Bernhard Bauer wrote:
> *Forced*SigninProcessor 😀

Done.

[Bernhard Bauer, 2015-09-21 14:24:31]

lgtm

[knn, 2015-09-21 14:34:39]

The CQ bit was checked by knn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-21 14:34:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357643002/40001

[commit-bot: I haz the power, 2015-09-21 14:36:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-21 14:36:18]

Dry run: Try jobs failed on following builders:
  ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)

[knn, 2015-09-22 09:46:08]

The CQ bit was checked by knn@chromium.org

[commit-bot: I haz the power, 2015-09-22 09:46:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1357643002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1357643002/40001

[commit-bot: I haz the power, 2015-09-22 09:46:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-22 09:47:18]

Patchset 3 (id:??) landed as
https://crrev.com/b022082dde8822156eb2fcd3a1c156b566119521
Cr-Commit-Position: refs/heads/master@{#350133}

[Primiano Tucci (use gerrit), 2015-09-23 22:25:01]

Why this patch was landed with
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

There has been ample discussion on chromium-dev. 
Those should be used only when reverting patches with the tree closed.

There was a good reason why this patch failed on Mac an Win bots: this patch as
it is is not compatible with case-insensitive filesystems. You are renaming a
file into itself (modulo the uppercase I)
As a result now trying to rebase CLs that have been developed before this patch
to a point after this patch, in Windows and Mac OS, is extremely hard. This
patch is now causing this:

First, rewinding head to replay your work on top of it...
error: The following untracked working tree files would be overwritten by
checkout:
       
chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunSigninProcessor.java

Git could be smarter with case insesitive filesystems, but as a general
principle there is no good reason for forcing NOTRY and NOPRESUBMIT just to get
away with CQ !

[dcheng, 2015-09-23 23:35:55]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1368553002/ by dcheng@chromium.org.

The reason for reverting is: Breaks git on case-insensitive filesystems..