DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8

DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8

V8DebuggerAgent was split into interface and implementation. All other agents should depend on the public part only.

Once InjectedScript, InjectedScriptHost and InjectedScriptManager are also moved to .../inspector/v8 some of the methods on V8DebuggerAgent will be removed and called only by the implementation classes.

BUG=439376
Committed: https://crrev.com/80862359ba867d2807e9ba7b366b352ee5cfda2b
Cr-Commit-Position: refs/heads/master@{#351166}

[yurys, 2015-09-25 23:01:22]

The CQ bit was checked by yurys@chromium.org to run a CQ dry run

[yurys, 2015-09-25 23:02:03]

yurys@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[commit-bot: I haz the power, 2015-09-25 23:03:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367623006/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367623006/1

[commit-bot: I haz the power, 2015-09-25 23:27:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-25 23:27:45]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dgozman, 2015-09-28 17:07:52]

https://codereview.chromium.org/1367623006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
(right):

https://codereview.chromium.org/1367623006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:42: ,
m_v8DebuggerAgent(V8DebuggerAgent::create(injectedScriptManager, debugger, this,
contextGroupId))
Let's move create method to V8Debugger and not pass debugger instance.

https://codereview.chromium.org/1367623006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1367623006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h:118: class
CORE_EXPORT AsyncCallTrackingListener : public WillBeGarbageCollectedMixin {
Let's merge this into Client and talk with V8AsyncCallTracker directly.

[yurys, 2015-09-28 17:59:49]

https://codereview.chromium.org/1367623006/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp
(right):

https://codereview.chromium.org/1367623006/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorDebuggerAgent.cpp:42: ,
m_v8DebuggerAgent(V8DebuggerAgent::create(injectedScriptManager, debugger, this,
contextGroupId))
On 2015/09/28 17:07:52, dgozman wrote:
> Let's move create method to V8Debugger and not pass debugger instance.

As discussed offline added a FIXME to the create method. We'll first need to
move injected script management into v8-inspector and come up with a structure
to store per context group data (similar to
WebDevToolsAgentImpl/WorkerInspectorController but operating in terms of
v8-inspector).

https://codereview.chromium.org/1367623006/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1367623006/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h:118: class
CORE_EXPORT AsyncCallTrackingListener : public WillBeGarbageCollectedMixin {
On 2015/09/28 17:07:52, dgozman wrote:
> Let's merge this into Client and talk with V8AsyncCallTracker directly.

Done.

[yurys, 2015-09-28 17:59:55]

The CQ bit was checked by yurys@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 18:03:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367623006/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367623006/60001

[dgozman, 2015-09-28 18:36:50]

lgtm

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h:124: virtual void
reset() = 0;
I think |reset| better fits into "API for the embedder" category.

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h (right):

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h:56: void
setInspectorState(InspectorState* state) { m_state = state; }
These methods should be marked "override".

[yurys, 2015-09-28 19:37:13]

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h (right):

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgent.h:124: virtual void
reset() = 0;
On 2015/09/28 18:36:50, dgozman wrote:
> I think |reset| better fits into "API for the embedder" category.

Done.

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h (right):

https://codereview.chromium.org/1367623006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h:56: void
setInspectorState(InspectorState* state) { m_state = state; }
On 2015/09/28 18:36:50, dgozman wrote:
> These methods should be marked "override".

Done.

[yurys, 2015-09-28 19:38:16]

The CQ bit was checked by yurys@chromium.org

[yurys, 2015-09-28 19:38:16]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1367623006/#ps80001
(title: " ")

[commit-bot: I haz the power, 2015-09-28 19:38:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367623006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367623006/80001

[commit-bot: I haz the power, 2015-09-28 19:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 19:58:55]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yurys, 2015-09-28 20:41:48]

The CQ bit was checked by yurys@chromium.org

[commit-bot: I haz the power, 2015-09-28 20:42:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1367623006/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1367623006/80001

[commit-bot: I haz the power, 2015-09-28 21:41:59]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-09-28 21:42:50]

Patchset 5 (id:??) landed as
https://crrev.com/80862359ba867d2807e9ba7b366b352ee5cfda2b
Cr-Commit-Position: refs/heads/master@{#351166}

[Lei Zhang, 2015-09-29 01:42:17]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1370373004/ by thestig@chromium.org.

The reason for reverting is: Broke oilpan:

In file included from gen/blink/core/InspectorInstrumentationImpl.cpp:10:
../../third_party/WebKit/Source/core/inspector/AsyncCallTracker.h:58:5: error:
only virtual member functions can be marked 'override'
    WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(AsyncCallTracker);
    ^
../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:210:53: note:
expanded from macro 'WILL_BE_USING_GARBAGE_COLLECTED_MIXIN'
#define WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(TYPE)
USING_GARBAGE_COLLECTED_MIXIN(TYPE)
                                                    ^
../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:199:5: note:
expanded from macro 'USING_GARBAGE_COLLECTED_MIXIN'
    DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS(blink::Visitor*, TYPE)       \
    ^
../../third_party/WebKit/Source/platform/heap/GarbageCollected.h:134:47: note:
expanded from macro 'DEFINE_GARBAGE_COLLECTED_MIXIN_METHODS'
    void adjustAndMark(VISITOR visitor) const override.

[pfeldman, 2015-09-29 05:06:17]

@thestig: I must have missed the announcement, are we now rolling out Oilpan
breakages on the main waterfall?