Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp

Issue 1367623006: DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp
diff --git a/third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.cpp b/third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp
similarity index 89%
rename from third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.cpp
rename to third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp
index 8e68a5daf6278a1082944439a8144929ef4374e5..a9dd4ff6626f56f134639c141b7695b6ca8b117f 100644
--- a/third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.cpp
+++ b/third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.cpp
@@ -3,7 +3,7 @@
// found in the LICENSE file.
#include "config.h"
-#include "core/inspector/V8AsyncCallTracker.h"
+#include "core/inspector/v8/V8AsyncCallTracker.h"
#include "bindings/core/v8/V8PerContextData.h"
#include "core/inspector/AsyncOperationMap.h"
@@ -26,7 +26,7 @@ static const char v8AsyncTaskEventDidHandle[] = "didHandle";
class V8AsyncCallTracker::V8ContextAsyncOperations final : public NoBaseWillBeGarbageCollectedFinalized<V8AsyncCallTracker::V8ContextAsyncOperations> {
WTF_MAKE_NONCOPYABLE(V8ContextAsyncOperations);
public:
- explicit V8ContextAsyncOperations(V8DebuggerAgent* debuggerAgent)
+ explicit V8ContextAsyncOperations(V8DebuggerAgentImpl* debuggerAgent)
: m_v8AsyncOperations(debuggerAgent)
{
}
@@ -61,17 +61,13 @@ static String makeV8AsyncTaskUniqueId(const String& eventName, int id)
return builder.toString();
}
-V8AsyncCallTracker::V8AsyncCallTracker(V8DebuggerAgent* debuggerAgent) : m_debuggerAgent(debuggerAgent)
+V8AsyncCallTracker::V8AsyncCallTracker(V8DebuggerAgentImpl* debuggerAgent) : m_debuggerAgent(debuggerAgent)
{
- m_debuggerAgent->addAsyncCallTrackingListener(this);
}
V8AsyncCallTracker::~V8AsyncCallTracker()
{
ASSERT(m_contextAsyncOperationMap.isEmpty());
-#if !ENABLE(OILPAN)
- m_debuggerAgent->removeAsyncCallTrackingListener(this);
-#endif
}
DEFINE_TRACE(V8AsyncCallTracker)
@@ -80,7 +76,6 @@ DEFINE_TRACE(V8AsyncCallTracker)
visitor->trace(m_contextAsyncOperationMap);
visitor->trace(m_debuggerAgent);
#endif
- V8DebuggerAgent::AsyncCallTrackingListener::trace(visitor);
}
void V8AsyncCallTracker::asyncCallTrackingStateChanged(bool)
@@ -136,7 +131,7 @@ void V8AsyncCallTracker::willHandleV8AsyncTask(ScriptState* state, const String&
m_debuggerAgent->traceAsyncCallbackStarting(contextCallChains->m_v8AsyncOperations.get(taskId));
contextCallChains->m_v8AsyncOperations.remove(taskId);
} else {
- m_debuggerAgent->traceAsyncCallbackStarting(V8DebuggerAgent::unknownAsyncOperationId);
+ m_debuggerAgent->traceAsyncCallbackStarting(V8DebuggerAgentImpl::unknownAsyncOperationId);
}
}

Powered by Google App Engine
This is Rietveld 408576698