Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Unified Diff: third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h

Issue 1367623006: DevTools: extract V8DebuggerAgent interface, move it under .../inspector/v8 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h
diff --git a/third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.h b/third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h
similarity index 75%
rename from third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.h
rename to third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h
index 87832d97c5c737f611cfa452faffc5f73e81cec4..ecc7ff3aa51fb01704689838e2891a5f2f6a85bf 100644
--- a/third_party/WebKit/Source/core/inspector/V8AsyncCallTracker.h
+++ b/third_party/WebKit/Source/core/inspector/v8/V8AsyncCallTracker.h
@@ -6,7 +6,7 @@
#define V8AsyncCallTracker_h
#include "bindings/core/v8/ScriptState.h"
-#include "core/inspector/V8DebuggerAgent.h"
+#include "core/inspector/v8/V8DebuggerAgentImpl.h"
#include "platform/heap/Handle.h"
#include "wtf/Forward.h"
#include "wtf/HashMap.h"
@@ -16,12 +16,12 @@ namespace blink {
class ScriptState;
-class V8AsyncCallTracker final : public NoBaseWillBeGarbageCollectedFinalized<V8AsyncCallTracker>, public ScriptState::Observer, public V8DebuggerAgent::AsyncCallTrackingListener {
+class V8AsyncCallTracker final : public NoBaseWillBeGarbageCollectedFinalized<V8AsyncCallTracker>, public ScriptState::Observer {
WTF_MAKE_NONCOPYABLE(V8AsyncCallTracker);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(V8AsyncCallTracker);
WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(V8AsyncCallTracker);
public:
- static PassOwnPtrWillBeRawPtr<V8AsyncCallTracker> create(V8DebuggerAgent* debuggerAgent)
+ static PassOwnPtrWillBeRawPtr<V8AsyncCallTracker> create(V8DebuggerAgentImpl* debuggerAgent)
{
return adoptPtrWillBeNoop(new V8AsyncCallTracker(debuggerAgent));
}
@@ -29,9 +29,8 @@ public:
~V8AsyncCallTracker();
DECLARE_TRACE();
- // V8DebuggerAgent::AsyncCallTrackingListener implementation:
- void asyncCallTrackingStateChanged(bool tracking) override;
- void resetAsyncOperations() override;
+ void asyncCallTrackingStateChanged(bool tracking);
+ void resetAsyncOperations();
void didReceiveV8AsyncTaskEvent(ScriptState*, const String& eventType, const String& eventName, int id);
@@ -39,14 +38,14 @@ public:
void willDisposeScriptState(ScriptState*) override;
private:
- explicit V8AsyncCallTracker(V8DebuggerAgent*);
+ explicit V8AsyncCallTracker(V8DebuggerAgentImpl*);
void didEnqueueV8AsyncTask(ScriptState*, const String& eventName, int id);
void willHandleV8AsyncTask(ScriptState*, const String& eventName, int id);
class V8ContextAsyncOperations;
WillBeHeapHashMap<RefPtr<ScriptState>, OwnPtrWillBeMember<V8ContextAsyncOperations>> m_contextAsyncOperationMap;
- RawPtrWillBeMember<V8DebuggerAgent> m_debuggerAgent;
+ RawPtrWillBeMember<V8DebuggerAgentImpl> m_debuggerAgent;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698