Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 1367023002: Replace timeout argument with IdleRequestOptions in requestIdleCallback. (Closed)

Created:
5 years, 3 months ago by rmcilroy
Modified:
5 years, 2 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@rIC_histograms
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace timeout argument with IdleRequestOptions in requestIdleCallback. Implements the changes in https://github.com/w3c/requestidlecallback/pull/22. BUG=514651 Committed: https://crrev.com/413acf4c5d70cb7404f4ee9e0310a12bf6955e99 Cr-Commit-Position: refs/heads/master@{#350811}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -20 lines) Patch
M third_party/WebKit/LayoutTests/virtual/threaded/fast/idle-callback/timeout.html View 3 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 2 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/Source/core/dom/IdleRequestOptions.idl View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/DOMWindow.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/LocalDOMWindow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteDOMWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteDOMWindow.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/Window.idl View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (7 generated)
rmcilroy
Jochen, could you take a look please.
5 years, 3 months ago (2015-09-24 20:19:35 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367023002/20001
5 years, 3 months ago (2015-09-24 20:20:52 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/123759) android_chromium_gn_compile_dbg on ...
5 years, 3 months ago (2015-09-24 20:36:16 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367023002/40001
5 years, 3 months ago (2015-09-24 20:38:21 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-24 23:45:20 UTC) #11
jochen (gone - plz use gerrit)
lgtm
5 years, 2 months ago (2015-09-25 11:12:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367023002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367023002/40001
5 years, 2 months ago (2015-09-25 13:05:42 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:40001)
5 years, 2 months ago (2015-09-25 13:11:26 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 13:12:03 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/413acf4c5d70cb7404f4ee9e0310a12bf6955e99
Cr-Commit-Position: refs/heads/master@{#350811}

Powered by Google App Engine
This is Rietveld 408576698