third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp - Issue 1367023002: Replace timeout argument with IdleRequestOptions in requestIdleCallback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

Issue 1367023002: Replace timeout argument with IdleRequestOptions in requestIdleCallback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@rIC_histograms

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.h ('k') | third_party/WebKit/Source/core/frame/DOMWindow.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

diff --git a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

index 5af71b0dbf8d4dc6b5f72fa0c255723046ac3ee9..8dfc911dc60ec5ff74a6be38ca140fadad1175ef 100644

--- a/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

+++ b/third_party/WebKit/Source/core/dom/ScriptedIdleTaskController.cpp

@@ -7,6 +7,7 @@

#include "core/dom/ExecutionContext.h"

#include "core/dom/IdleRequestCallback.h"

+#include "core/dom/IdleRequestOptions.h"

#include "core/inspector/InspectorTraceEvents.h"

#include "platform/Logging.h"

#include "platform/TraceEvent.h"

@@ -76,15 +77,16 @@ DEFINE_TRACE(ScriptedIdleTaskController)

ActiveDOMObject::trace(visitor);

}

-ScriptedIdleTaskController::CallbackId ScriptedIdleTaskController::registerCallback(IdleRequestCallback* callback, double timeoutMillis)

+ScriptedIdleTaskController::CallbackId ScriptedIdleTaskController::registerCallback(IdleRequestCallback* callback, const IdleRequestOptions& options)

{

CallbackId id = ++m_nextCallbackId;

m_callbacks.set(id, callback);

+ long long timeoutMillis = options.timeout();

RefPtr<internal::IdleRequestCallbackWrapper> callbackWrapper = internal::IdleRequestCallbackWrapper::create(id, this);

m_scheduler->postIdleTask(FROM_HERE, WTF::bind<double>(&internal::IdleRequestCallbackWrapper::idleTaskFired, callbackWrapper));

if (timeoutMillis > 0)

- m_scheduler->timerTaskRunner()->postDelayedTask(FROM_HERE, WTF::bind(&internal::IdleRequestCallbackWrapper::timeoutFired, callbackWrapper), static_cast<long long>(timeoutMillis));

+ m_scheduler->timerTaskRunner()->postDelayedTask(FROM_HERE, WTF::bind(&internal::IdleRequestCallbackWrapper::timeoutFired, callbackWrapper), timeoutMillis);

TRACE_EVENT_INSTANT1("devtools.timeline", "RequestIdleCallback", TRACE_EVENT_SCOPE_THREAD, "data", InspectorIdleCallbackRequestEvent::data(executionContext(), id, timeoutMillis));

return id;

}