Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Issue 1342143002: [Histograms]: Add histograms for requestIdleCallback. (Closed)

Created:
5 years, 3 months ago by rmcilroy
Modified:
5 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Histograms]: Add histograms for requestIdleCallback. Updates histograms.xml to include UMA metrics added to Blink in https://codereview.chromium.org/1344053002. Also update UseCounter histograms to add missing values (by running update_use_counter_feature_enum.py) to include the following new values: - HeaderValueNotMatchingRFC7230 - ClipPathOfPositionedElement - ClipCssOfPositionedElement - NetInfoType - NetInfoDownlinkMax - NetInfoOnChange - NetInfoOnTypeChange - V8Window_Alert_Method - V8Window_Confirm_Method - V8Window_Prompt_Method - V8Window_Print_Method - V8Window_RequestIdleCallback_Method BUG=514651 Committed: https://crrev.com/1e9d97bcc03b5c3a62ca2a68491095350d1ee0ce Cr-Commit-Position: refs/heads/master@{#349085}

Patch Set 1 : #

Total comments: 5

Patch Set 2 : Address Ilya's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 2 chunks +31 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (6 generated)
rmcilroy
Ilya, could you please review this change, thanks.
5 years, 3 months ago (2015-09-15 17:22:29 UTC) #3
Ilya Sherman
LGTM % nits https://codereview.chromium.org/1342143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1342143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode50851 tools/metrics/histograms/histograms.xml:50851: + The amount of time that ...
5 years, 3 months ago (2015-09-15 21:56:22 UTC) #4
rmcilroy
https://codereview.chromium.org/1342143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1342143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode50851 tools/metrics/histograms/histograms.xml:50851: + The amount of time that a requestIdleCallback callback ...
5 years, 3 months ago (2015-09-15 23:18:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342143002/40001
5 years, 3 months ago (2015-09-16 00:01:06 UTC) #8
Ilya Sherman
(Still LGTM) https://codereview.chromium.org/1342143002/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1342143002/diff/20001/tools/metrics/histograms/histograms.xml#newcode50851 tools/metrics/histograms/histograms.xml:50851: + The amount of time that a ...
5 years, 3 months ago (2015-09-16 00:55:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/104491)
5 years, 3 months ago (2015-09-16 01:33:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1342143002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1342143002/40001
5 years, 3 months ago (2015-09-16 08:19:43 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 3 months ago (2015-09-16 09:59:04 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/1e9d97bcc03b5c3a62ca2a68491095350d1ee0ce Cr-Commit-Position: refs/heads/master@{#349085}
5 years, 3 months ago (2015-09-16 10:00:01 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:54:02 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/1e9d97bcc03b5c3a62ca2a68491095350d1ee0ce
Cr-Commit-Position: refs/heads/master@{#349085}

Powered by Google App Engine
This is Rietveld 408576698