Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: content/common/child_process_host_impl.cc

Issue 1367013003: ipc: Change the timing of the construction of the attachment broker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ipc/attachment_broker.cc » ('j') | ipc/attachment_broker.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/child_process_host_impl.cc
diff --git a/content/common/child_process_host_impl.cc b/content/common/child_process_host_impl.cc
index 071d96d207d0c424f5a0976a885a1dc3f96e7a4e..4c6107ff7ee45c56fc36247fb3812e423c487bce 100644
--- a/content/common/child_process_host_impl.cc
+++ b/content/common/child_process_host_impl.cc
@@ -111,6 +111,14 @@ ChildProcessHostImpl::ChildProcessHostImpl(ChildProcessHostDelegate* delegate)
#if defined(OS_WIN)
AddFilter(new FontCacheDispatcher());
#endif
+#if USE_ATTACHMENT_BROKER
+ // Ensure that the privileged attachment broker gets constructed early in the
+ // life cycle of making a child process. This ensures that when a test is
Tom Sepez 2015/09/25 15:37:34 nit: just "life cycle of a child process".
erikchen 2015/09/25 19:27:04 Done.
+ // being run one of the single process modes, the global attachment broker is
Tom Sepez 2015/09/25 15:37:34 nit: "being run in one of the"
erikchen 2015/09/25 19:27:04 Done.
+ // the privileged attachment broker, rather than an unprivileged attachment
+ // broker.
+ GetAttachmentBroker();
+#endif
}
ChildProcessHostImpl::~ChildProcessHostImpl() {
« no previous file with comments | « no previous file | ipc/attachment_broker.cc » ('j') | ipc/attachment_broker.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698