ipc/attachment_broker.cc - Issue 1367013003: ipc: Change the timing of the construction of the attachment broker.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/attachment_broker.cc

Issue 1367013003: ipc: Change the timing of the construction of the attachment broker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ipc/attachment_broker.cc

diff --git a/ipc/attachment_broker.cc b/ipc/attachment_broker.cc

index 362fc1f52235b138553dd6d1d33effdd8d7a79a5..7e04bcd645de09dd4a4a32e3cd8f6198c567926d 100644

--- a/ipc/attachment_broker.cc

+++ b/ipc/attachment_broker.cc

@@ -14,10 +14,7 @@ namespace IPC {

// static

void AttachmentBroker::SetGlobal(AttachmentBroker* broker) {

- // TODO(erikchen): There should be a CHECK here to make sure that

- // |g_attachment_broker| is nullptr. Right now, this causes problems with

- // --single_process and similar testing conditions. I'm temporarily removing

- // this CHECK. http://crbug.com/534539.

+ CHECK(!g_attachment_broker);

Tom Sepez 2015/09/25 15:37:34 check vs. DCHECK? your call. I'd expect a DCHECK.

erikchen 2015/09/25 19:27:04 I think this is important to check, even in offici

g_attachment_broker = broker;

}

« content/common/child_process_host_impl.cc ('K') | « content/common/child_process_host_impl.cc ('k') | no next file » | no next file with comments »