ipc: Change the timing of the construction of the attachment broker.

content/common/child_process_host_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/common/child_process_host_impl.h"
 
 #include <limits>
 
 #include "base/atomic_sequence_num.h"
 #include "base/command_line.h"
@@ skipping 93 matching lines @@
     PathService::Get(CHILD_PROCESS_EXE, &child_path);
   return child_path;
 }
 
 ChildProcessHostImpl::ChildProcessHostImpl(ChildProcessHostDelegate* delegate)
     : delegate_(delegate),
       opening_channel_(false) {
 #if defined(OS_WIN)
   AddFilter(new FontCacheDispatcher());
 #endif
+#if USE_ATTACHMENT_BROKER
+  // Ensure that the privileged attachment broker gets constructed early in the
+  // life cycle of making a child process. This ensures that when a test is

[Tom Sepez, 2015/09/25 15:37:34]

nit: just "life cycle of a child process".

[erikchen, 2015/09/25 19:27:04]

Done.

+  // being run one of the single process modes, the global attachment broker is

[Tom Sepez, 2015/09/25 15:37:34]

nit: "being run in one of the"

[erikchen, 2015/09/25 19:27:04]

Done.

+  // the privileged attachment broker, rather than an unprivileged attachment
+  // broker.
+  GetAttachmentBroker();
+#endif
 }
 
 ChildProcessHostImpl::~ChildProcessHostImpl() {
 #if USE_ATTACHMENT_BROKER
   GetAttachmentBroker()->DeregisterCommunicationChannel(channel_.get());
 #endif
   for (size_t i = 0; i < filters_.size(); ++i) {
     filters_[i]->OnChannelClosing();
     filters_[i]->OnFilterRemoved();
   }
@@ skipping 204 matching lines @@
 }
 
 void ChildProcessHostImpl::OnDeletedGpuMemoryBuffer(
     gfx::GpuMemoryBufferId id,
     uint32 sync_point) {
   // Note: Nothing to do here as ownership of shared memory backed
   // GpuMemoryBuffers is passed with IPC.
 }
 
 }  // namespace content