Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 136693017: A64: Fix the order of pushing general and FP safepoint registers. (Closed)

Created:
6 years, 10 months ago by ulan
Modified:
6 years, 10 months ago
Reviewers:
Alexandre Rames
CC:
v8-dev
Visibility:
Public.

Description

A64: Fix the order of pushing general and FP safepoint registers. TEST=mjsunit/elements-transition R=alexandre.rames@arm.com Committed: https://code.google.com/p/v8/source/detail?r=19103

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M src/a64/lithium-codegen-a64.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ulan
PTAL. The frame iterator expects to see FP registers below the general registers in the ...
6 years, 10 months ago (2014-02-05 13:39:52 UTC) #1
Alexandre Rames
LGTM. Sorry about that.
6 years, 10 months ago (2014-02-05 13:41:10 UTC) #2
ulan
Committed patchset #1 manually as r19103 (presubmit successful).
6 years, 10 months ago (2014-02-05 13:46:06 UTC) #3
ulan
6 years, 10 months ago (2014-02-05 13:48:27 UTC) #4
Message was sent while issue was closed.
> LGTM. Sorry about that.

No worries =)

Powered by Google App Engine
This is Rietveld 408576698