Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Side by Side Diff: src/a64/lithium-codegen-a64.h

Issue 136693017: A64: Fix the order of pushing general and FP safepoint registers. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 354 matching lines...) Expand 10 before | Expand all | Expand 10 after
365 : codegen_(codegen) { 365 : codegen_(codegen) {
366 ASSERT(codegen_->info()->is_calling()); 366 ASSERT(codegen_->info()->is_calling());
367 ASSERT(codegen_->expected_safepoint_kind_ == Safepoint::kSimple); 367 ASSERT(codegen_->expected_safepoint_kind_ == Safepoint::kSimple);
368 codegen_->expected_safepoint_kind_ = kind; 368 codegen_->expected_safepoint_kind_ = kind;
369 369
370 switch (codegen_->expected_safepoint_kind_) { 370 switch (codegen_->expected_safepoint_kind_) {
371 case Safepoint::kWithRegisters: 371 case Safepoint::kWithRegisters:
372 codegen_->masm_->PushSafepointRegisters(); 372 codegen_->masm_->PushSafepointRegisters();
373 break; 373 break;
374 case Safepoint::kWithRegistersAndDoubles: 374 case Safepoint::kWithRegistersAndDoubles:
375 codegen_->masm_->PushSafepointRegisters();
375 codegen_->masm_->PushSafepointFPRegisters(); 376 codegen_->masm_->PushSafepointFPRegisters();
376 codegen_->masm_->PushSafepointRegisters();
377 break; 377 break;
378 default: 378 default:
379 UNREACHABLE(); 379 UNREACHABLE();
380 } 380 }
381 } 381 }
382 382
383 ~PushSafepointRegistersScope() { 383 ~PushSafepointRegistersScope() {
384 Safepoint::Kind kind = codegen_->expected_safepoint_kind_; 384 Safepoint::Kind kind = codegen_->expected_safepoint_kind_;
385 ASSERT((kind & Safepoint::kWithRegisters) != 0); 385 ASSERT((kind & Safepoint::kWithRegisters) != 0);
386 switch (kind) { 386 switch (kind) {
387 case Safepoint::kWithRegisters: 387 case Safepoint::kWithRegisters:
388 codegen_->masm_->PopSafepointRegisters(); 388 codegen_->masm_->PopSafepointRegisters();
389 break; 389 break;
390 case Safepoint::kWithRegistersAndDoubles: 390 case Safepoint::kWithRegistersAndDoubles:
391 codegen_->masm_->PopSafepointFPRegisters();
391 codegen_->masm_->PopSafepointRegisters(); 392 codegen_->masm_->PopSafepointRegisters();
392 codegen_->masm_->PopSafepointFPRegisters();
393 break; 393 break;
394 default: 394 default:
395 UNREACHABLE(); 395 UNREACHABLE();
396 } 396 }
397 codegen_->expected_safepoint_kind_ = Safepoint::kSimple; 397 codegen_->expected_safepoint_kind_ = Safepoint::kSimple;
398 } 398 }
399 399
400 private: 400 private:
401 LCodeGen* codegen_; 401 LCodeGen* codegen_;
402 }; 402 };
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
457 457
458 protected: 458 protected:
459 MacroAssembler* masm() const { return codegen_->masm(); } 459 MacroAssembler* masm() const { return codegen_->masm(); }
460 460
461 LCodeGen* codegen_; 461 LCodeGen* codegen_;
462 }; 462 };
463 463
464 } } // namespace v8::internal 464 } } // namespace v8::internal
465 465
466 #endif // V8_A64_LITHIUM_CODEGEN_A64_H_ 466 #endif // V8_A64_LITHIUM_CODEGEN_A64_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698