Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 136683004: Removes MessageLoop::TYPE_XXX where possible (Closed)

Created:
6 years, 11 months ago by sky
Modified:
6 years, 11 months ago
CC:
chromium-reviews, weitaosu+watch_chromium.org, nkostylev+watch_chromium.org, tzik, shishir+watch_chromium.org, alecflett, rpetterson, gavinp+memory_chromium.org, dgrogan, kinuko+watch, stevenjb+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, jam, joi+watch-content_chromium.org, wez+watch_chromium.org, darin-cc_chromium.org, groby+spellwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, android-webview-reviews_chromium.org, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, fischman+watch_chromium.org, sanjeevr, rouslan+spellwatch_chromium.org, nhiroki, feature-media-reviews_chromium.org, rmsousa+watch_chromium.org, oshima+watch_chromium.org, sergeyu+watch_chromium.org, zork+watch_chromium.org, michaeln, hclam+watch_chromium.org, jsbell, tfarina, mcasas+watch_chromium.org, amit, garykac+watch_chromium.org, dominich+watch_chromium.org, lambroslambrou+watch_chromium.org, cmumford, alexeypa+watch_chromium.org, wjia+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Removes MessageLoop::TYPE_XXX where possible This is part of attempting to get rid of MessageLoop::Type enum. BUG=none TEST=none R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244996

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : resolve merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -151 lines) Patch
M android_webview/browser/net/android_stream_reader_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M base/cancelable_callback_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M base/memory/discardable_memory_provider_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M base/timer/timer_unittest.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 7 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/api/declarative_webrequest/webrequest_rules_registry_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/dial/dial_service_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/default_apps_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/external_policy_loader_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/importer/profile_writer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/net/chrome_fraudulent_certificate_reporter_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/net/connection_tester_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/policy/url_blacklist_manager_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_table_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/predictors/autocomplete_action_predictor_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/profile_resetter/profile_resetter_unittest.cc View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_database_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_host_metrics_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync_file_system/local/local_file_change_tracker_unittest.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/themes/theme_syncable_service_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/media/chrome_webrtc_log_message_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/gcp20/prototype/gcp20_device.cc View 1 chunk +1 line, -1 line 0 comments Download
M cloud_print/service/service_state.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/appcache/chrome_appcache_service_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/loader/resource_scheduler_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_input_device_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/audio_mirroring_manager_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/media/device_request_message_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/video_capture_manager_unittest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/resolve_proxy_msg_helper_unittest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/streams/stream_url_request_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/child/resource_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_broker_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/audio_message_filter_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/renderer/pepper/pepper_graphics_2d_host_unittest.cc View 1 chunk +1 line, -3 lines 0 comments Download
M device/bluetooth/bluetooth_chromeos_unittest.cc View 21 chunks +21 lines, -21 lines 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M gin/modules/timer_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_input_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/user_input_monitor_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/stress_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/embedded_test_server_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/dump_files.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/dump_cache/upgrade_win.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/tools/fetch/fetch_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/proxy/ppb_message_loop_proxy.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/shared_impl/tracked_callback_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M remoting/host/daemon_process_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/native_messaging/native_messaging_reader_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M remoting/host/win/worker_process_launcher_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M tools/ipc_fuzzer/replay/replay_process.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/message_center/message_center_impl_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
sky
6 years, 11 months ago (2014-01-13 17:01:41 UTC) #1
darin (slow to review)
LGTM!!
6 years, 11 months ago (2014-01-14 06:00:42 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/136683004/30001
6 years, 11 months ago (2014-01-14 16:59:46 UTC) #3
commit-bot: I haz the power
Failed to apply patch for base/memory/discardable_memory_provider_unittest.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 11 months ago (2014-01-14 17:00:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/136683004/140001
6 years, 11 months ago (2014-01-14 20:25:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/136683004/140001
6 years, 11 months ago (2014-01-14 23:24:25 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/136683004/140001
6 years, 11 months ago (2014-01-15 02:53:39 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44865
6 years, 11 months ago (2014-01-15 16:25:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sky@chromium.org/136683004/140001
6 years, 11 months ago (2014-01-15 16:32:34 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=44896
6 years, 11 months ago (2014-01-15 18:22:31 UTC) #10
sky
6 years, 11 months ago (2014-01-15 22:24:45 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 manually as r244996.

Powered by Google App Engine
This is Rietveld 408576698