Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc

Issue 136683004: Removes MessageLoop::TYPE_XXX where possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: resolve merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
diff --git a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
index b350afc5c14dcd6362a1715c20e14193985f1007..05c9d622c89d1ff139272551309955f01d878381 100644
--- a/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
+++ b/chrome/browser/extensions/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
@@ -32,7 +32,7 @@ namespace keys = declarative_webrequest_constants;
TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
std::string error;
scoped_refptr<const WebRequestConditionAttribute> result;
@@ -73,7 +73,7 @@ TEST(WebRequestConditionAttributeTest, CreateConditionAttribute) {
TEST(WebRequestConditionAttributeTest, ResourceType) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
std::string error;
base::ListValue resource_types;
@@ -106,7 +106,7 @@ TEST(WebRequestConditionAttributeTest, ResourceType) {
TEST(WebRequestConditionAttributeTest, ContentType) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
std::string error;
scoped_refptr<const WebRequestConditionAttribute> result;
@@ -177,7 +177,7 @@ TEST(WebRequestConditionAttributeTest, ContentType) {
// Testing WebRequestConditionAttributeThirdParty.
TEST(WebRequestConditionAttributeTest, ThirdParty) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
std::string error;
const FundamentalValue value_true(true);
@@ -239,7 +239,7 @@ TEST(WebRequestConditionAttributeTest, ThirdParty) {
// applicable in all stages.
TEST(WebRequestConditionAttributeTest, Stages) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
typedef std::pair<RequestStage, const char*> StageNamePair;
static const StageNamePair active_stages[] = {
@@ -418,7 +418,7 @@ void MatchAndCheck(const std::vector< std::vector<const std::string*> >& tests,
// by both types of condition attributes, so it is enough to test it once.
TEST(WebRequestConditionAttributeTest, RequestHeaders) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
net::TestURLRequestContext context;
net::TestDelegate delegate;
@@ -498,7 +498,7 @@ TEST(WebRequestConditionAttributeTest, RequestHeaders) {
// 3. Negating the match in case of 'doesNotContainHeaders'.
TEST(WebRequestConditionAttributeTest, ResponseHeaders) {
// Necessary for TestURLRequest.
- base::MessageLoop message_loop(base::MessageLoop::TYPE_IO);
+ base::MessageLoopForIO message_loop;
net::SpawnedTestServer test_server(
net::SpawnedTestServer::TYPE_HTTP,

Powered by Google App Engine
This is Rietveld 408576698