Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Side by Side Diff: chrome/browser/custom_handlers/protocol_handler_registry_unittest.cc

Issue 136683004: Removes MessageLoop::TYPE_XXX where possible (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: resolve merge Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/custom_handlers/protocol_handler_registry.h" 5 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/memory/scoped_ptr.h" 9 #include "base/memory/scoped_ptr.h"
10 #include "base/message_loop/message_loop.h" 10 #include "base/message_loop/message_loop.h"
(...skipping 264 matching lines...) Expand 10 before | Expand all | Expand 10 after
275 }; 275 };
276 276
277 // URLRequest DCHECKS that the current MessageLoop is IO. It does this because 277 // URLRequest DCHECKS that the current MessageLoop is IO. It does this because
278 // it can't check the thread id (since net can't depend on content.) We want 278 // it can't check the thread id (since net can't depend on content.) We want
279 // to harness our tests so all threads use the same loop allowing us to 279 // to harness our tests so all threads use the same loop allowing us to
280 // guarantee all messages are processed.) By overriding the IsType method 280 // guarantee all messages are processed.) By overriding the IsType method
281 // we basically ignore the supplied message loop type, and instead infer 281 // we basically ignore the supplied message loop type, and instead infer
282 // our type based on the current thread. GO DEPENDENCY INJECTION! 282 // our type based on the current thread. GO DEPENDENCY INJECTION!
283 class TestMessageLoop : public base::MessageLoop { 283 class TestMessageLoop : public base::MessageLoop {
284 public: 284 public:
285 TestMessageLoop() : base::MessageLoop(base::MessageLoop::TYPE_DEFAULT) {} 285 TestMessageLoop() {}
286 virtual ~TestMessageLoop() {} 286 virtual ~TestMessageLoop() {}
287 virtual bool IsType(base::MessageLoop::Type type) const OVERRIDE { 287 virtual bool IsType(base::MessageLoop::Type type) const OVERRIDE {
288 switch (type) { 288 switch (type) {
289 #if defined(TOOLKIT_GTK) 289 #if defined(TOOLKIT_GTK)
290 case base::MessageLoop::TYPE_GPU: 290 case base::MessageLoop::TYPE_GPU:
291 #endif 291 #endif
292 case base::MessageLoop::TYPE_UI: 292 case base::MessageLoop::TYPE_UI:
293 return BrowserThread::CurrentlyOn(BrowserThread::UI); 293 return BrowserThread::CurrentlyOn(BrowserThread::UI);
294 case base::MessageLoop::TYPE_IO: 294 case base::MessageLoop::TYPE_IO:
295 return BrowserThread::CurrentlyOn(BrowserThread::IO); 295 return BrowserThread::CurrentlyOn(BrowserThread::IO);
(...skipping 627 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 923
924 TEST_F(ProtocolHandlerRegistryTest, MAYBE_TestInstallDefaultHandler) { 924 TEST_F(ProtocolHandlerRegistryTest, MAYBE_TestInstallDefaultHandler) {
925 RecreateRegistry(false); 925 RecreateRegistry(false);
926 registry()->AddPredefinedHandler(CreateProtocolHandler( 926 registry()->AddPredefinedHandler(CreateProtocolHandler(
927 "test", GURL("http://test.com/%s"), "Test")); 927 "test", GURL("http://test.com/%s"), "Test"));
928 registry()->InitProtocolSettings(); 928 registry()->InitProtocolSettings();
929 std::vector<std::string> protocols; 929 std::vector<std::string> protocols;
930 registry()->GetRegisteredProtocols(&protocols); 930 registry()->GetRegisteredProtocols(&protocols);
931 ASSERT_EQ(static_cast<size_t>(1), protocols.size()); 931 ASSERT_EQ(static_cast<size_t>(1), protocols.size());
932 } 932 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698