chrome/browser/interstitials/security_interstitial_page.h - Issue 1365733005: Split captive portal metrics out of SSLErrorClassification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/interstitials/security_interstitial_page.h

Issue 1365733005: Split captive portal metrics out of SSLErrorClassification (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clean up before review Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/interstitials/chrome_metrics_helper.cc ('K') | « chrome/browser/interstitials/chrome_metrics_helper.cc ('k') | chrome/browser/interstitials/security_interstitial_page.cc » ('j') | chrome/browser/safe_browsing/safe_browsing_blocking_page.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/interstitials/security_interstitial_page.h

diff --git a/chrome/browser/interstitials/security_interstitial_page.h b/chrome/browser/interstitials/security_interstitial_page.h

index 0bd632bd65fa8bb8dd4bf093b8414dbb65fc6460..13c547df6856bdd94876345d9bef74c8b600436f 100644

--- a/chrome/browser/interstitials/security_interstitial_page.h

+++ b/chrome/browser/interstitials/security_interstitial_page.h

@@ -99,7 +99,7 @@ class SecurityInterstitialPage : public content::InterstitialPageDelegate {

security_interstitials::MetricsHelper* metrics_helper() const;

void set_metrics_helper(

- security_interstitials::MetricsHelper* metrics_helper);

+ scoped_ptr<security_interstitials::MetricsHelper> metrics_helper);

private:

scoped_ptr<security_interstitials::MetricsHelper> metrics_helper_;