Split captive portal metrics out of SSLErrorClassification

chrome/browser/interstitials/chrome_metrics_helper.cc

Index: chrome/browser/interstitials/chrome_metrics_helper.cc
diff --git a/chrome/browser/interstitials/chrome_metrics_helper.cc b/chrome/browser/interstitials/chrome_metrics_helper.cc
index c886e448d1dea7fc45755200c84c92080a056990..5e4b9f80ed9a0b1b2b6f125641560ebcaa049c58 100644
--- a/chrome/browser/interstitials/chrome_metrics_helper.cc
+++ b/chrome/browser/interstitials/chrome_metrics_helper.cc
@@ -7,6 +7,7 @@
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/history/history_service_factory.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ssl/captive_portal_metrics_helper.h"
 #include "components/history/core/browser/history_service.h"
 #include "components/rappor/rappor_service.h"
 #include "content/public/browser/web_contents.h"
@@ -35,6 +36,18 @@ ChromeMetricsHelper::ChromeMetricsHelper(
 
 ChromeMetricsHelper::~ChromeMetricsHelper() {}
 
+void ChromeMetricsHelper::StartRecordingCaptivePortalMetrics(bool overridable) {
+  captive_portal_helper_.reset(
+      new CaptivePortalMetricsHelper(web_contents_, overridable));
+}
+
+void ChromeMetricsHelper::RecordExtraShutdownMetrics() {
+  // The captive portal metrics should be recorded when the interstitial is
+  // closing (or destructing).
+  if (captive_portal_helper_.get())

[estark, 2015/09/25 23:53:34]

no `.get()` necessary

[felt, 2015/09/27 20:08:15]

Done.

+    captive_portal_helper_->RecordCaptivePortalUMAStatistics();
+}
+
 void ChromeMetricsHelper::RecordExtraUserDecisionMetrics(
     security_interstitials::MetricsHelper::Decision decision) {
 #if defined(ENABLE_EXTENSIONS)